Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Alternate thumbnail embedder - tageditor #12459

Open
DoctorVanGogh opened this issue Mar 15, 2017 · 1 comment
Open

Feature Request: Alternate thumbnail embedder - tageditor #12459

DoctorVanGogh opened this issue Mar 15, 2017 · 1 comment

Comments

@DoctorVanGogh
Copy link

@DoctorVanGogh DoctorVanGogh commented Mar 15, 2017

  • I've verified and I assure that I'm running youtube-dl 2017.03.15

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Feature request (request for a new functionality)

Description of your issue, suggested solution and other information

I'd like to propose an alternative to atomicparsley for thumbnail embedding: tageditor (https://github.com/Martchus/tageditor). It's supports mp4 and mkv embedding of cover images (among quite a lot of other things).

Example command line:

tageditor -set cover="foo.png" -f "foo.mp4"  [--max-padding nnnn]

Might be able to resolve #10359.

If using an alternate external application for thumbnail embedding is already supported, at least --help doesn't mention it.

@Tatsh
Copy link
Contributor

@Tatsh Tatsh commented Mar 13, 2018

Looking into this because AtomicParsley as it is currently distributed is a bit dated. For those who want to build it locally they may have more luck but having an alternative is definitely good, especially if the only thing we use it for is thumbnails. MP4Box of GPAC could also be used, but that only supports MPEG-4 files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.