Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[adobepass] Add MSOs #12581
[adobepass] Add MSOs #12581
Comments
|
That depends. The general rule is to have a separate PR for a separate functionality or a feature. |
Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2017.03.26. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
Description of your issue, suggested solution and other information
I have a question before I submit any pull requests. I have some proposed changes for adobepass, but I wondered if it was better to add one MSO at a time and wait for testing, than to add several MSOs at once. In other words, should I submit separate pull requests as they're approved, even though it's one file being updated? I think I've found a way to make all MSOs work as long as they are in the dict, but have no way of testing more than one.