Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adobepass] Add MSOs #12581

Closed
gkoelln opened this issue Mar 27, 2017 · 1 comment
Closed

[adobepass] Add MSOs #12581

gkoelln opened this issue Mar 27, 2017 · 1 comment

Comments

@gkoelln
Copy link
Contributor

@gkoelln gkoelln commented Mar 27, 2017

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.03.26. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.03.26

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

I have a question before I submit any pull requests. I have some proposed changes for adobepass, but I wondered if it was better to add one MSO at a time and wait for testing, than to add several MSOs at once. In other words, should I submit separate pull requests as they're approved, even though it's one file being updated? I think I've found a way to make all MSOs work as long as they are in the dict, but have no way of testing more than one.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Mar 27, 2017

That depends. The general rule is to have a separate PR for a separate functionality or a feature.

@dstftw dstftw closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.