Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bilibili]Can't support a video containing many pages. #12654

Open
cmershen1 opened this issue Apr 5, 2017 · 4 comments
Open

[bilibili]Can't support a video containing many pages. #12654

cmershen1 opened this issue Apr 5, 2017 · 4 comments
Labels

Comments

@cmershen1
Copy link

@cmershen1 cmershen1 commented Apr 5, 2017


Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.04.03. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.04.03

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


for example,the URL http://www.bilibili.com/video/av9291699
there are 4 videos in it.but if I use the command youtube-dl -F http://www.bilibili.com/video/av9595179

I can only see the information about the first video:

[BiliBili] 9595179: Downloading webpage
[BiliBili] 9595179: Downloading video info page
[info] Available formats for 9595179:
format code  extension  resolution note
0            mp4        unknown
1            mp4        unknown    369.28MiB (best)

Only if I execute youtube-dl -F http://www.bilibili.com/video/av9595179/index_1.html to youtube-dl -F http://www.bilibili.com/video/av9595179/index_4.html can I download all the 4 videos correctly.Can you fix it?or tell me the way to parse how many videoes in an ID.

@cqnkxy
Copy link

@cqnkxy cqnkxy commented Apr 16, 2017

I think we may need a playlist extractor. If you're interested, the videos are listed inside the div with id=plist, even if the page only contains a single video. You can add this playlist extractor fairly easily by looking at some examples like the one in nba.py. But one problem like I said is that there is no way to differentiate a single video and a playlist then. I need to modify the _real_extract to add a recursion depth limit to avoid infinite recursion call. I don't know if this is desired. So the simple solution would still be to only download the video you're currently visiting.

@cqnkxy
Copy link

@cqnkxy cqnkxy commented Apr 17, 2017

Here is my example change. I am not gonna make a pull request because I am not sure if this feature is desired. But if you are interested you can pull the code and have a try.

@yan12125 yan12125 added the request label Apr 17, 2017
@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Apr 17, 2017

@cqnkxy That looks good, just with quite a few coding-style issues. Feel free to open an pull request if you want it supported in mainline youtube-dl.

@cqnkxy
Copy link

@cqnkxy cqnkxy commented Apr 18, 2017

@yan12125 Thanks! Actually I've had a editor plugin checked the style already, but still... I'll open a pull request and look forward to your comments! Please tell me when it looks good enough and I'll rebase the previous commits into one. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.