Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
NBC Crashes #13651
Closed
NBC Crashes #13651
Labels
Comments
|
can be fixed by always passing permalinks with |
|
I can confirm the fix works. |
|
I can confirm that both the issue still happens in the 2017.7.15 version, and taking the 's' out of the https:// link does allow the program to work again |
Closed
|
This is a free video that requires no login and this is what I'm getting: |
|
@gkoelln try to use |
|
Taking the 's' out of 'https' was working with --hls-prefer-native for American Ninja Warrior, but now it no longer works. |
|
Like PRMan99 said, these fixes aren't working for me. This is an SNL episode. |
|
forcing http works for me including with ANW. |
|
I'm not sure it's clear (you can sort of tell from the title of the dupe, #13715, NBC no longer works), but this is a regression. So 2eeb588 by @remitamine fixing #12364. Oh, hey, #12364 is my PR. Whoops… |
|
Now the youtube-dl version has come to 2017.8.27, BUT the problem of nbc still remains. |
|
American Ninja Warrior has been working except one episode (Denver first round) where there is a malformed XML error that apparently doesn't affect the player but affects YouTube-DL. I've been able to download every episode since using a combination of http instead of https and --hls-prefer-native. |
Closed
Still not working. I'm using a local proxy. |
|
This is coming back as an empty array |
|
As I wrote in August, this was broken by #12364
I haven't had a chance to look at it, but the old version works fine. Reverting #12364 in the interim is probably worth it, but of course someone should take the time to find the problem [and add a test!] |
|
as i said before this can be simply fixed just by always using _VALID_URL = r'(?P<permalink>https?://(?:www\.)?nbc\.com/[^/]+/video/[^/]+/(?P<id>n?\d+))'to _VALID_URL = r'https?(?P<permalink>://(?:www\.)?nbc\.com/[^/]+/video/[^/]+/(?P<id>n?\d+))'and add this line: permalink = 'http' + permalinkafter this line: permalink, video_id = re.match(self._VALID_URL, url).groups() |
|
@remitamine Why don't you create a Pull Request then? |
|
|
I spent 3 hours trying to get Python setup enough to actually run
youtube-dl.
Can somebody point me to a pre-made virtual machine that can compile this
with simple instructions or a list of instructions that works on a Windows
10 PC (unlike every set of instructions online, none of which work).
…On Sun, Oct 1, 2017 at 2:29 PM, remitamine ***@***.***> wrote:
@snipem <https://github.com/snipem>
and i also said in other issues that i have problems in my netbook that
prevent me from contributing to the project.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13651 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATZBWOhb0e6R-cn--Q9p8sfzhULrIYaeks5soARWgaJpZM4OYyA4>
.
|
|
Well, the only recommendation I can give you, is to use a Mac or a Linux virtual machine instead. Setting up Scripting languages on Windows is a hassle. I'll give @remitamine 's proposal a shot |
|
@remitamine Your changes seem to work and I've created a Pull Request. Can you please release your code snippets as Public Domain. A comment in the Pull Request should be enough. |
|
Thanks, guys.
If you have a VM that's set up or instructions for Linux, I can always set
up Ubuntu on Windows 10 or a VM.
…On Tue, Oct 3, 2017 at 7:51 AM, remitamine ***@***.***> wrote:
Closed #13651 <#13651> via bfd484c
<bfd484c>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13651 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATZBWOq3vXFEgz34CUqKMobMgEyyfOvXks5sokoFgaJpZM4OYyA4>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like that [x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2017.07.09. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add
-vflag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):
Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
NBC videos were last know to work on or before 7/12/2017 now no videos can be download without youtube-dl crashing