Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Improvements for Upskill Courses (Isolate Teachable methods, group by Chapter and new link structure) #13886

Closed
leocaseiro opened this issue Aug 11, 2017 · 1 comment

Comments

@leocaseiro
Copy link

@leocaseiro leocaseiro commented Aug 11, 2017

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.08.09. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.08.09

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl for upskillcourse extractor)
  • Feature request (request for a new functionality): adding chapters for upskillcourse

Teachable websites

Upskill (http://upskillcourses.com/) is part of the https://teachable.com/ Learning Courses Websites, so we could isolate its methods to be reused in other websites such as ultimateangular.com, and the examples http://learn.vrdev.school/?src=teachable-examples or http://courses.every-tuesday.com/p/brush-lettering-with-watercolor/?src=teachable-examples.

I'm not a python developer, but I'd suggest creating an abstract class (or similar within Python syntax) and them the upskill would extend abstract teachable extractor class and set its URL formats and some specific names if needed to.

link with /p/ calling generic instead

The link http://upskillcourses.com/p/essential-web-developer-course is not being recognized by youtube-dl, only the link http://upskillcourses.com/courses/enrolled/119763

Group videos by chapter

Teachable websites have chapters and it would be nice be able to save videos within subfolders from its chapters. As well as use on -o to rename files, like: %(chapter_number)s and/or %(chapter)s


Below I set a list of the fix/improvements mentioned in this issue:


Possible related issues

#13043
#13203

@leocaseiro
Copy link
Author

@leocaseiro leocaseiro commented Jan 23, 2019

@leocaseiro leocaseiro closed this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.