Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bandcamp] wrong title for albums, programming help #13927

Closed
steebchen opened this issue Aug 16, 2017 · 1 comment
Closed

[bandcamp] wrong title for albums, programming help #13927

steebchen opened this issue Aug 16, 2017 · 1 comment

Comments

@steebchen
Copy link
Contributor

@steebchen steebchen commented Aug 16, 2017

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.08.13. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.08.13

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Bandcamp titles are not extracted in albums, e.g. http://music.businesscasual.biz/album/--8 only extracts the URLs. I want to extract the title but am not sure how to do it.

On this line:
https://github.com/rg3/youtube-dl/blob/485047854376465f95309daad4966971f56728ef/youtube_dl/extractor/bandcamp.py#L245
the div with the title is extracted already. I thought about using _html_search_meta, but it seems it only searches for the content attribute and not the actual innerText of the element – I'd like to extract it from the itemprop="name" selector.

bandcamp html:
selection_103

Is there another way to do this or do I need to extend the beautiful RegExp (still missing a proper HTML parser instead of using RegExp for this...)?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Aug 16, 2017

_search_regex.

@dstftw dstftw closed this Aug 16, 2017
@steebchen steebchen mentioned this issue Aug 18, 2017
4 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.