Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert subtitles to lrc? #14292

Closed
DuendeInexistente opened this issue Sep 21, 2017 · 1 comment
Closed

Convert subtitles to lrc? #14292

DuendeInexistente opened this issue Sep 21, 2017 · 1 comment

Comments

@DuendeInexistente
Copy link

@DuendeInexistente DuendeInexistente commented Sep 21, 2017

This one is simple: Youtube-dl gives an option to convert subtitles to a desired format, but lrc isn't one of the provided options. Adding support for it would be trivial (Ffmpeg already does it on it's own) and, I think, it'd be a great help when downloading music from such channels which add subtitles to all their songs.

I already checked out --exec to do this, but that runs commands with the file's full name, while the subtitle always differs slightly from the video. Embedding the subtitle into the file and converting that could also work I guess, but my experience is that sometimes (I think when multiple formats are mixed into a mkv container?) subtitle embedding just fails.


Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.09.15. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.09.15

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other
@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Sep 22, 2017

Ffmpeg already does it on it's own

Good to know that! lrc will be accepted as a subtitle conversion target in the next version.

@yan12125 yan12125 closed this in 8c28953 Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.