Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Suggestion for signature change problems #1430
Comments
|
El sep 15, 2013 7:08 a.m., "Elite" notifications@github.com escribió:
I agree completely, but i would take it a one step ahead: Instead of having the signatures embeded in the py files, why don't we put I'll see if I can come up with a patch
|
|
This has been suggested before, and I'm against it - I'd rather have 1. auto-update for fixes we cannot foresee and 2. automatic signature extraction on the client side, which doesn't need any infrastructure. |
|
@phihag What could be possibly wrong with the above approach - we are wasting no resources (both client and server) as signatures should only be fetched as an "error catch" when 403 happens, also your second approach does seem more practical. |
|
@Elite Restricting auto-update to a very small error case doesn't help when something else changes (say, YouTube names its signature k, or adds a new primitive, or blip.tv breaks). So if there is an update system, it should apply to the whole source code. And updated signatures should be handled locally, there's no reason to involve a server. |
YT signature change has been one of the major reasons for broken functionality every now and then, how about implementing a logic like this ::
If there is a 403 error check a github url for new signature and save them for future use. This way the request is only made when 403 is encountered and no action needs to be taken part on user's front while app remains functional and most up-to-date :)