Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for signature change problems #1430

Closed
Elite opened this issue Sep 15, 2013 · 4 comments
Closed

Suggestion for signature change problems #1430

Elite opened this issue Sep 15, 2013 · 4 comments

Comments

@Elite
Copy link

@Elite Elite commented Sep 15, 2013

YT signature change has been one of the major reasons for broken functionality every now and then, how about implementing a logic like this ::

If there is a 403 error check a github url for new signature and save them for future use. This way the request is only made when 403 is encountered and no action needs to be taken part on user's front while app remains functional and most up-to-date :)

@jsargiot
Copy link

@jsargiot jsargiot commented Sep 15, 2013

El sep 15, 2013 7:08 a.m., "Elite" notifications@github.com escribió:

YT signature change has been one of the major reasons for broken
functionality every now and then, how about implementing a logic like this
::

If there is a 403 error check a github url for new signature and save
them for future use. This way the request is only made when 403 is
encountered and no action needs to be taken part on user's front while app
remains functional and most up-to-date :)

I agree completely, but i would take it a one step ahead:

Instead of having the signatures embeded in the py files, why don't we put
them on separate files and update only those files since the logic
remains...

I'll see if I can come up with a patch


Reply to this email directly or view it on GitHub.

@phihag
Copy link
Contributor

@phihag phihag commented Sep 16, 2013

This has been suggested before, and I'm against it - I'd rather have 1. auto-update for fixes we cannot foresee and 2. automatic signature extraction on the client side, which doesn't need any infrastructure.

@phihag phihag closed this Sep 16, 2013
@Elite
Copy link
Author

@Elite Elite commented Sep 16, 2013

@phihag What could be possibly wrong with the above approach - we are wasting no resources (both client and server) as signatures should only be fetched as an "error catch" when 403 happens, also your second approach does seem more practical.

@phihag
Copy link
Contributor

@phihag phihag commented Sep 16, 2013

@Elite Restricting auto-update to a very small error case doesn't help when something else changes (say, YouTube names its signature k, or adds a new primitive, or blip.tv breaks). So if there is an update system, it should apply to the whole source code. And updated signatures should be handled locally, there's no reason to involve a server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.