Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Build youtube-dl.exe as 2 files (library and exe loader) [required for signing the executable] #14367

Closed
romaincointepas opened this issue Sep 30, 2017 · 2 comments

Comments

@romaincointepas
Copy link

@romaincointepas romaincointepas commented Sep 30, 2017

Follow-up to #10372.

In order to sign a py2exe executable on Windows with SignTools, the library and the exe loader have to be detached (there is no other way as far as I know).

This blog post explains this very well:
https://medium.com/@bjoernstiel/code-signing-py2exe-executables-a222c0d06d3f
(It seems that the only thing to do is pass the option zipfile = "app.lib", right now it is set to None).

This is mostly required when shipping youtube-dl with signed Electron/nw.js apps (when the packager signs the main executables and all other executables shipped with the app).

Just to clarify, there is no need for the official youtube-dl.exe to be signed, the best approach would be to release an additional build of youtube-dl for Windows that would be 2 files: the youtube-dl-loader.exe and youtube-dl.lib (or something similar)?

@yan12125 Thoughts?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Sep 30, 2017

You can build youtube-dl whichever way you like. Releasing additional builds for specific corner cases is not an option.

@dstftw dstftw closed this Sep 30, 2017
@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Sep 30, 2017

I guess using official Python binaries from https://www.python.org/ with https://yt-dl.org/downloads/latest/youtube-dl is enough. You can just run python.exe youtube-dl and use it like youtube-dl.exe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.