Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Filename Template: Format, Quality, and Resolution Substitution Tags #1445

Closed
EveryDirection opened this issue Sep 17, 2013 · 6 comments
Closed
Labels

Comments

@EveryDirection
Copy link

@EveryDirection EveryDirection commented Sep 17, 2013

For the -o or --output option, looking at the documentation obtained via --help, there's currently no tags for format, quality, or resolution. For example, if we are downloading a YouTube video in 720p MP4 (format 22: mp4 [720x1280]), we should have tags to enable writing the following to the filename template:

%(format)s -> "22"
%(quality)s -> "720p"
%(resolution)s -> (whatever the true resolution of the video may be, which is not necessarily 720x1280 though it'll be in that range)

This seems to be a very simple feature to add that wouldn't take much coding, and it would be very helpful when downloading files in varying qualities. Thanks.

@EveryDirection
Copy link
Author

@EveryDirection EveryDirection commented Sep 18, 2013

Actually, instead of %(resolution)s, you'd probably want to split it up for finer control and to allow the user to use whatever ordering (width x height or height x width) the user prefers:

%(height)s
%(width)s

@EveryDirection
Copy link
Author

@EveryDirection EveryDirection commented Dec 15, 2013

So, sometime in the past couple of months or so, the following tags (with examples) did get added to the program:

%(format)s -> "22 - 1280x720"
%(format_id)s -> "22"

which I do appreciate, but it'd be nice if we could get finer control over those; there's still no

%(quality)s
%(height)s
%(width)s

tags.

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Dec 15, 2013

The height and witdth parameters are supported in some extractors (like vimeo, ted, gametrailers, mtv, comedycentral ...), but we need to migrate the youtube extractor to the new formats system.

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Mar 3, 2014

All the tags are now supported for youtube videos, thanks for the report.

@jaimeMF jaimeMF closed this Mar 3, 2014
@EveryDirection
Copy link
Author

@EveryDirection EveryDirection commented Mar 4, 2014

I just downloaded version 2014.03.03 to test.

There's no documentation on these tags via --help, which should be added.

%(height)s and %(width)s are supported now (thanks!). But %(quality)s and %(resolution)s remain unsupported --- not that they necessarily have to be supported, since they can be constructed out of the %(height)s and %(width)s tags, but since there's no actual documentation in the program on which tags are supported, I just thought I'd point that out here in case anyone was wondering exactly what is meant by "all" tags now being supported.

phihag added a commit that referenced this issue Mar 4, 2014
@phihag
Copy link
Contributor

@phihag phihag commented Mar 4, 2014

@EveryDirection Thank you for the note. I've documented height, width, and resolution, and set a sensible default if the latter is not set, but width and height are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.