Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--convert-subs doesn't work when with --skip-download #14454

Closed
scil opened this issue Oct 9, 2017 · 2 comments
Closed

--convert-subs doesn't work when with --skip-download #14454

scil opened this issue Oct 9, 2017 · 2 comments
Labels

Comments

@scil
Copy link
Contributor

@scil scil commented Oct 9, 2017

for example:

--write-sub --write-auto-sub --convert-subs srt --skip-download     
-o "%(title)s.%(ext)s"  
https://www.youtube.com/watch?v=Fnynf9Wy8IY

a vtt format sub file download, but it has not been converted to srt.
because YoutubeDL not run post_process , which requires --skip-download is False:

        if not self.params.get('skip_download', False):
                ...
                try:
                    self.post_process(filename, info_dict)

https://github.com/rg3/youtube-dl/blob/89923316210f8e17bb1a085278940e1c56fcff48/youtube_dl/YoutubeDL.py#L1818

Maybe some post processors that convert sub files can run even if there is no video downloaded.

@dstftw dstftw closed this Oct 9, 2017
@dstftw dstftw added the duplicate label Oct 9, 2017
@sivagao
Copy link

@sivagao sivagao commented Nov 27, 2017

why close this issue?
do you have any plan to resolve this?

@lweo
Copy link

@lweo lweo commented Feb 3, 2019

It's so inconvenient! why converting vtt to srt must require downloading the video first? I don't understand...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.