Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnDemandKorea Subtitle Download REQ #14486

Closed
h1pp0 opened this issue Oct 13, 2017 · 1 comment
Closed

OnDemandKorea Subtitle Download REQ #14486

h1pp0 opened this issue Oct 13, 2017 · 1 comment

Comments

@h1pp0
Copy link

@h1pp0 h1pp0 commented Oct 13, 2017

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.10.12. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.10.12

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • [x ] Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.


Hello,

Can you please add support for downloading of subtitles. OnDemandKorea stores them as .vtt

Parsing the html code for ".vtt" will return a list of urls for the subtitle files. The language is prepended prior to the extension for example:
English subs will be: http://www.ondemandkorea.com/subtitles/vtt/take-good-care-of-the-fridge-e150.1507763202038.en.vtt

@h1pp0 h1pp0 closed this Oct 13, 2017
@h1pp0
Copy link
Author

@h1pp0 h1pp0 commented Oct 13, 2017

This can be done by adding the params; --sub-lang en --write-sub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.