Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description field for new tests - use text or md5 prefix? #14510

Closed
parmjitv opened this issue Oct 16, 2017 · 1 comment
Closed

Description field for new tests - use text or md5 prefix? #14510

parmjitv opened this issue Oct 16, 2017 · 1 comment
Labels

Comments

@parmjitv
Copy link
Contributor

@parmjitv parmjitv commented Oct 16, 2017

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.10.15.1. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.10.15.1

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Hello All,

Regarding the tests in place for a given extractor, the description field is set as either a literal text string or as a MD5 checksum value. For example:

'description': 'Here is a literal text description of a video clip.'
-vs-
'description': 'md5:f3ceb5ef83a08d95b9d146f973157cc8'

When adding a new test for an extractor, when is it appropriate to use the 'md5:' prefix for the description field?

Many thanks,

Parmjit V.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Oct 16, 2017

md5 is usually used for a long description strings.

@dstftw dstftw closed this Oct 16, 2017
@dstftw dstftw added the question label Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.