Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFmpegFixupM3u8PP] prevent unnecessary re-run on resuming list download #14577

Closed
lkho opened this issue Oct 24, 2017 · 1 comment
Closed

[FFmpegFixupM3u8PP] prevent unnecessary re-run on resuming list download #14577

lkho opened this issue Oct 24, 2017 · 1 comment

Comments

@lkho
Copy link
Contributor

@lkho lkho commented Oct 24, 2017

  • I've verified and I assure that I'm running youtube-dl 2017.10.20
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Feature request (request for a new functionality)
  • Question

currently FFmpegFixupM3u8PP will run if using hlsnative and audio is aac.
https://github.com/rg3/youtube-dl/blob/cdd1ce92c46167c12514a061609308112e79ea84/youtube_dl/YoutubeDL.py#L1947
https://github.com/rg3/youtube-dl/blob/cdd1ce92c46167c12514a061609308112e79ea84/youtube_dl/postprocessor/ffmpeg.py#L541
Thus the processor will be invoked on existing downloaded files even those have been already processed before (if youtube-dl is called with a list of urls, and not overwriting). This makes the url list not resume-able (logically can resume, skipping the download but the post process still run and takes time, thus make the skip useless).

Can this be prevented by some sort of file renaming/ADTS detection beforehand so that the post process is run only once when a list is being resumed?

attached the ffprobe output of a fragment before and after running -bsf:a aac_adtstoasc

fragment
a.ts.gz
ffprobe -show_streams -print_format json a.ts
a.ts.txt
ffmpeg -i a.ts -c copy -bsf:a aac_adtstoasc a.mp4
ffprobe -show_streams -print_format json a.mp4
a.mp4.txt

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Oct 24, 2017

Use --download-archive.

@dstftw dstftw closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.