Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[gamespot] Add support for video embeds in article pages(was: RegexNotFoundError: Unable to extract data video) #14652
Comments
AddendumMore luck with this URL This is the Share link from within the player controls. But: The Embed link does not work: But: PS E:\Test>
>> curl.exe -s "https://www.gamespot.com/videos/embed/6441610/" |
>> pup -p "div.js-video-player-new.av-video-player.av-desktop-player.av-video-on-demand.is-vid-noseek.is-vid-show-controls.is-vid-uvpjs-player attr{data-video}" |
>> jq '.videoStreams .adaptive_hd'
>>
"https://gamespot-vh.akamaihd.net/i/d5/2017/10/30/Trailer_LastofUs_PGW_20171030_,4000,.mp4.csmil/master.m3u8"
PS E:\Test>Edit:Single line: curl.exe -s "https://www.gamespot.com/videos/embed/6441610/" | pup -p "div.js-video-player-new.av-video-player.av-desktop-player.av-video-on-demand.is-vid-noseek.is-vid-show-controls.is-vid-uvpjs-player attr{data-video}" | jq '.videoStreams .adaptive_hd' |
|
@remitamine I think this issue has been mentioned on the Changelog/Relnotes, so what's the status on this? Still fixes in the pipeline? |
video and embed pages support has been fixed, video embeds in articles pages are not supported yet, it's easy to add support for them but i'm not working on it for now, |
remitamine
changed the title
|
Isn't that the video with additional ~ 15s advertising at the beginning? Edit: Yes. PS E:\Test> youtube-dl --ignore-config --verbose "https://www.gamespot.com/videos/embed/6441610/"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ignore-config', '--verbose', 'https://www.gamespot.com/videos/embed/6441610/']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.11.06
[debug] Python version 3.4.4 - Windows-10-10.0.16299
[debug] exe versions: ffmpeg 3.4, ffprobe 3.4
[debug] Proxy map: {}
[GameSpot] 6441610: Downloading webpage
[GameSpot] 6441610: Downloading m3u8 information
[GameSpot] 6441610: Downloading m3u8 information
[GameSpot] 6441610: Checking http-2000 video format URL
[GameSpot] 6441610: Checking http-4400 video format URL
[GameSpot] 6441610: Checking http-3000 video format URL
[GameSpot] 6441610: Checking http-1200 video format URL
[GameSpot] 6441610: Checking http-764 video format URL
[GameSpot] 6441610: Checking http-512 video format URL
[GameSpot] 6441610: Checking http-264 video format URL
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'http://once.unicornmedia.com/now/media/progressive/f35627fb-e0cc-43bb-ac38-859bab1493ff/0df57330-950f-4947-9946-833815cf6612/468fb310-a585-11e4-bfdb-005056837bc7/6441610/content.mp4'
[download] The Last Of Us Part II - PGW 2017 Trailer-gs-2300-6441610.mp4 has already been downloaded
[download] 100% of 164.29MiB
PS E:\Test> MediaInfo '.\The Last Of Us Part II - PGW 2017 Trailer-gs-2300-6441610.mp4' | sls "Duration|Width|Height"
Duration : 5 min 13 s
Duration : 5 min 12 s
Width : 1 280 pixels
Height : 720 pixels
Duration : 5 min 13 s
Duration : 5 min 12 s
Duration : 5 min 13 s
PS E:\Test>Using the URL from embed page above, extracted from the doc PS E:\Test> youtube-dl --ignore-config --verbose --hls-prefer-native "https://gamespot-vh.akamaihd.net/i/d5/2017/10/30/Trailer_LastofUs_PGW_20171030_,4000,.mp4.csmil/master.m3u8"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ignore-config', '--verbose', '--hls-prefer-native', 'https://gamespot-vh.akamaihd.net/i/d5/2017/10/30/Trailer_LastofUs_PGW_20171030_,4000,.mp4.csmil/master.m3u8']
[debug] Encodings: locale cp1252, fs mbcs, out cp65001, pref cp1252
[debug] youtube-dl version 2017.11.06
[debug] Python version 3.4.4 - Windows-10-10.0.16299
[debug] exe versions: ffmpeg 3.4, ffprobe 3.4
[debug] Proxy map: {}
[generic] master: Requesting header
WARNING: Could not send HEAD request to https://gamespot-vh.akamaihd.net/i/d5/2017/10/30/Trailer_LastofUs_PGW_20171030_,4000,.mp4.csmil/master.m3u8: HTTP Error 405: Method Not Allowed
[generic] master: Downloading webpage
[generic] master: Downloading m3u8 information
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'https://gamespot-vh.akamaihd.net/i/d5/2017/10/30/Trailer_LastofUs_PGW_20171030_,4000,.mp4.csmil/index_0_av.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 30
[download] Destination: master-master.mp4
[download] 100% of 141.07MiB in 00:35
[debug] ffmpeg command line: ffprobe -show_streams "file:master-master.mp4"
[ffmpeg] Fixing malformed AAC bitstream in "master-master.mp4"
[debug] ffmpeg command line: ffmpeg -y -i "file:master-master.mp4" -c copy -f mp4 "-bsf:a" aac_adtstoasc "file:master-master.temp.mp4"
PS E:\Test> MediaInfo .\master-master.mp4 | sls "duration|width|height"
Duration : 4 min 57 s
Duration : 4 min 57 s
Width : 1 920 pixels
Height : 1 080 pixels
Duration : 4 min 57 s
PS E:\Test> |
|
|
|
Call of Duty: WWII ad at the beginning And 720p vs. 1080p, obviously. |
the 1080p is not selected because the 720p has higher bitrate, the ads are only included in the |
|
in the next release, article pages will be supported and formats that has ads will be skipped. |
|
Awesome, thanks a lot! |
|
Were reviews ever supported?
|
|
Nope, looks like that URL format is not supported.. Can you access the same vid with another URL? Like, something along the lines of |
|
you can download this video using share URL(https://www.gamespot.com/videos/gears-of-war-video-review/2300-6161200/ or https://www.gamespot.com/videos/embed/6161200/), downloading from review URLs will be supported in the next version. |
Yes, I found the URL eventually via the share menu. Initially I used Google to search under |
|
@remitamine Yes, I successfully downloaded the video.
|
|
This page fails (from the PC version review): Perhaps the age-gated videos aren't supported? |
no, it's not it just requires more changes to the extractor, you can download the video using https://gamespot-pdl.akamaized.net/d3/gsc/2007/11/169_gearsofwar_vr_01_pc_110507_hr.mp4. |
I've verified and I assure that I'm running youtube-dl 2017.10.29
At least skimmed through the README, most notably the FAQ and BUGS sections
Searched the bugtracker for similar issues including closed ones
What is the purpose of your issue?
GameSpot.com extraction broken, due to site change I assume.
Example URL:
https://www.gamespot.com/articles/the-last-of-us-2-receives-new-ps4-trailer/1100-6454469/