Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Support --get-duration Tag (Reoppened) #14664

Closed
DanielnetoDotCom opened this issue Nov 3, 2017 · 1 comment
Closed

Site Support --get-duration Tag (Reoppened) #14664

DanielnetoDotCom opened this issue Nov 3, 2017 · 1 comment
Labels

Comments

@DanielnetoDotCom
Copy link

@DanielnetoDotCom DanielnetoDotCom commented Nov 3, 2017

Hi I have opened this before #14661

But an collaborator has close this issue and I found no way to reopen it.

He already tell me my site is not explicitly supported and extraction is delegated to generic extractor that may or may not succeed. You can mask your data behind any pattern generic extractor supports to make it succeed (see the extractor/generic.py).

https://github.com/rg3/youtube-dl/blob/master/youtube_dl/extractor/generic.py

I have looked into the file above and I have not found hot to make YouPHPTube youtube-dl suported?
Should I add some tag information? or change the youtube-dl code?
BTW, the issue is about the duration, title and thumbs works fine

Thanks

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Nov 4, 2017

Again: this depends on a particular site and how this site embeds videos. Generic extractor only sequentially tries known patterns and uses one that is matched (again, see the code for these patterns). If such pattern supports duration extraction and it's properly provided by a site, it will be extracted then.

@dstftw dstftw closed this Nov 4, 2017
@dstftw dstftw added the duplicate label Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.