Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test fail due to missing 'id' and 'ext' in test case specification #14855

Closed
ghost opened this issue Nov 26, 2017 · 0 comments
Closed

Some test fail due to missing 'id' and 'ext' in test case specification #14855

ghost opened this issue Nov 26, 2017 · 0 comments

Comments

@ghost
Copy link

@ghost ghost commented Nov 26, 2017

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.11.15. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.11.15

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

Some testl cases in the extractors do not supply an 'id' or 'ext' yielding errors like

======================================================================
ERROR: test_ORFTVthek_2 (test.test_download.TestDownload):
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../youtube-dl-2017.11.15/youtube-dl/test/test_download.py", line 110, in test_template
    raise Exception('Test definition incorrect. The output file cannot be known. Are both \'id\' and \'ext\' keys present?')
Exception: Test definition incorrect. The output file cannot be known. Are both 'id' and 'ext' keys present?

(Note that test_ORFTVthek_2 is an automatically generated function).
The reason for this error is that the some test cases in youtube_dl/extractors/orf.py do not have a 'id' or 'ext' entry. It seems that this is not a problem with the test as it has the 'skip_download': True entry, but more a shortcoming of the generic implementation which enforces the existence of 'id' and 'ext' and errors out otherwise.

Other tests with the same deficiency:

  • test_ORFTVthek_2 (test.test_download.TestDownload) defined in file youtube_dl/extractors/orf.py
  • test_ORFTVthek_3 (test.test_download.TestDownload) defined in file youtube_dl/extractors/orf.py
  • test_Rozhlas_1 (test.test_download.TestDownload) defined in file youtube_dl/extractors/rozhlas.py
  • test_Vidzi_1 (test.test_download.TestDownload) defined in file youtube_dl/extractors/vidzi.py
  • test_Vidzi_2 (test.test_download.TestDownload) defined in file youtube_dl/extractors/vidzi.py
  • test_YoukuShow_2 (test.test_download.TestDownload) defined in file youtube_dl/extractors/youku.py
@dstftw dstftw closed this in 7512aa9 Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
0 participants
You can’t perform that action at this time.