Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
`test/test_youtube_signature.py` not excluded in target `offlinetest` #14858
Comments
|
Thanks for the report - fixed. |
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like this:[x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2017.11.26. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The tests in
test/test_youtube_signature.pyneed internet access (they usecompat_urlretrieve()).However, this file is not excluded in the
offlinetesttarget inMakefile.Suggested fix: add
--exclude test_youtube_signature.pyto this target.