Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep even when file already existed. #14878

Closed
DeadSix27 opened this issue Nov 30, 2017 · 0 comments
Closed

Sleep even when file already existed. #14878

DeadSix27 opened this issue Nov 30, 2017 · 0 comments
Labels

Comments

@DeadSix27
Copy link

@DeadSix27 DeadSix27 commented Nov 30, 2017

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality) (kind of)
  • Question
  • Other

  • I've verified and I assure that I'm running youtube-dl 2017.11.26
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

It could be similar to: #4924 but afaik that post had no fix, this one does.


In the common downloader: https://github.com/rg3/youtube-dl/blob/master/youtube_dl/downloader/common.py#L351
The code does not sleep when a file is already downloaded, despite sleep_interval being set which is an issue on some sites, e.g NicoNico, which even when you do not download the file give you a error 503 when requesting too many videos in short time.

One way to solve this would be something like:
https://github.com/DeadSix27/youtube-dl/commit/4a386648cf85511d9eb283ba488858b6a5dc2444.patch but there are probably other approaches too.

@dstftw dstftw closed this Dec 2, 2017
@dstftw dstftw added the duplicate label Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.