Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with so many open PRs #15045

Open
1 of 5 tasks
mariuszskon opened this issue Dec 21, 2017 · 5 comments
Open
1 of 5 tasks

Dealing with so many open PRs #15045

mariuszskon opened this issue Dec 21, 2017 · 5 comments

Comments

@mariuszskon
Copy link

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

So it appears that youtube-dl is, well, struggling with a pull request overload. This issue is to discuss possible solutions for this. I am not trying to start any controversy, just to make everyone aware of the problem.

I believe that in a large part, there are two main sub-issues here:

  1. Not enough maintainers. @dstftw is the only really active maintainer, and he cannot be expected to do almost all of the work.

  2. Plenty of old PRs that should have been closed or merged by now. See [joemonster] Add new extractor #5177 and [walla] Fixed extractor and added site-wide video extraction #5163 for PRs that are surely dead, or TVI/IOL extractor #7080 and [iTunes] Add new extractor #14202 for ones where the submitter has received no response from maintainers for quite a long time.

I have no suggested solutions for this, so I wish to get some discussion going.

@sleske
Copy link
Contributor

sleske commented Dec 22, 2017

Yes, my thought exactly. I submitted a PR (#14598) that seems to have been ignored completely. It's frustrating to submit PRs and not even get a one-line response.

At the same time, I'm willing to volunteer to review PRs, if that is desired.
Maybe the project can establish a list of "PR reviewers" or "PR triagers" who can check incoming PRs. These people can work without full commit/merge rights at first, but could e.g. tag PRs that look fine for final review and merge (tag "ready-to-merge"), or they could approve a PR in a pull request reviews. Then a "full member" with write access can just do a quick final check & merge.

@WPFilmmaker
Copy link

My two cents as non-dev, why not spending a period (a week?) just focusing on PRs ?

@gardenappl
Copy link
Contributor

gardenappl commented Aug 18, 2020

Ironically, this very issue is also dead.

@mariuszskon
Copy link
Author

mariuszskon commented Aug 19, 2020

I was considering starting a "proper" fork which is more aggressive in terms of accepting new extractor pull requests, but I am afraid it might get out of hand quickly.

@gardenappl
Copy link
Contributor

Have you thought about doing something like this?

I’m closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on for so long, then it seems no one has the time to implement this.

Please reopen if you still encounter this issue with the [latest stable version](http://owncloud.org/install/) and then please use the [issue template](https://raw.github.com/owncloud/core/master/issue_template.md). You can also contribute directly by providing a patch – see the [developer manual](http://doc.owncloud.org/server/9.0/developer_manual/). :)

Thank you!

Obviously I'm not a youtube-dl maintainer, just throwing my 2 cents, waiting for my own PR to get reviewed. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants