Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dramafever: %(title)s does not include episode number #15492

Closed
GeorgeHamp opened this issue Feb 4, 2018 · 1 comment
Closed

Dramafever: %(title)s does not include episode number #15492

GeorgeHamp opened this issue Feb 4, 2018 · 1 comment

Comments

@GeorgeHamp
Copy link

@GeorgeHamp GeorgeHamp commented Feb 4, 2018

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.02.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.02.04

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

[debug] User config: ['-o', '%(title)s.%(ext)s', '--all-subs', '--limit-rate', '1M']
[debug] Command-line args: ['http://www.dramafever.com/drama/4044/1/Flower_Boy_Ramen_Shop/?ap=1']
[download] Destination: Flower Boy Ramen Shop.flv


Unlike most other streaming services, %(title)s does not include the episode number for series on Dramafever. This causes errors / overwritten files when trying to download series without changing the user-config first.
As the majority of content on this streaming service is serialized, it might be a good idea to include the episode number in %(title)s

The issue may be linked to #13699
I guess both, series-id and episode-number have been removed following that issue - but the episode-number is usefull ;)

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 4, 2018

You are using output template without id so all bets are off, now you are responsible for naming. title is not supposed to be unique. If you want episode number to be included include it on your own.

@dstftw dstftw closed this Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.