Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for download() function #15795

Closed
killown opened this issue Mar 8, 2018 · 1 comment
Closed

Suggestion for download() function #15795

killown opened this issue Mar 8, 2018 · 1 comment

Comments

@killown
Copy link

@killown killown commented Mar 8, 2018

Do something like that for download() function

def download(self, url):
     url_list = url
     if type(url) == str:
         url_list = [url]
    """Download a given list of URLs."""
    outtmpl = self.params.get('outtmpl', DEFAULT_OUTTMPL)
    if (len(url_list) > 1 and
            outtmpl != '-' and
            '%' not in outtmpl and
            self.params.get('max_downloads') != 1):
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Mar 8, 2018

Don't see much point in that. Doc string is clear about what type of argument you should pass.

@dstftw dstftw closed this Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.