Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instagram] Certificate error with python3 #1589

Open
jaimeMF opened this issue Oct 11, 2013 · 2 comments
Open

[instagram] Certificate error with python3 #1589

jaimeMF opened this issue Oct 11, 2013 · 2 comments

Comments

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Oct 11, 2013

The test for instagram is currently failing in python 3: https://travis-ci.org/rg3/youtube-dl/jobs/12415785#L284, with this error:

ssl.CertificateError: hostname 'distilleryvesper11-19.ak.instagram.com' doesn't match either of '*.akamaihd.net', '*.akamaihd-staging.net', 'a248.e.akamai.net'

We should add a warning and use http in python3, and maybe disable the test.

@phihag
Copy link
Contributor

@phihag phihag commented Oct 13, 2013

This looks like SAN is not supported in Python. Maybe we can patch it in?

@jaimeMF
Copy link
Collaborator Author

@jaimeMF jaimeMF commented Oct 13, 2013

The funny thing is that the travis test passes now, while I still get the error in my computer.
I have tested with the last version of wget (1.14), aria2c and Firefox and all of them complain about the certificate, which I think they support SAN.
I know little about certificates, but the certifcate only list three possible domains: *.akamaihd.net, *.akamaihd-staging.net and a248.e.akamai.net, how would you patch it to don't fail if the actual host is distilleryvesper11-19.ak.instagram.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.