Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for partially recorded Twitch videos. #16259

Closed
chrisgavin opened this issue Apr 23, 2018 · 6 comments
Closed

Better handling for partially recorded Twitch videos. #16259

chrisgavin opened this issue Apr 23, 2018 · 6 comments
Labels

Comments

@chrisgavin
Copy link
Contributor

@chrisgavin chrisgavin commented Apr 23, 2018

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.04.16. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.04.16

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

When using youtube-dl to archive a particular Twitch channel, if the channel is currently broadcasting you will only obtain a partial recording of the current broadcast. This partial recording is recorded in the download archive the same way as any other recording, therefore it will never be updated, even when the full recording becomes available.

Not downloading partially recorded videos is actually quite easy, the JSON response from the Twitch API lists the video as "status": "recording", so I'm mostly opening this issue as a discussion on how this should be implemented. Should there just be a flag to not download partial recordings (or should it even be the default when downloading a playlist/channel)? Should they be downloaded, but recorded differently in the download archive so a complete copy will still be downloaded when it is ready? I'd be very interested to hear what more experienced youtube-dl developers think.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 24, 2018

@dstftw dstftw closed this Apr 24, 2018
@dstftw dstftw added the duplicate label Apr 24, 2018
@chrisgavin
Copy link
Contributor Author

@chrisgavin chrisgavin commented Apr 24, 2018

Ah, awesome. It's good to know there's a known way to implement it. So I should just fix the Twitch extractor so it sets the is_live property correctly?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 24, 2018

This will skip all live streams like https://www.twitch.tv/paradoxinteractive. I don't know whether this will work in your case - you did not provide any example URL.

@chrisgavin
Copy link
Contributor Author

@chrisgavin chrisgavin commented Apr 24, 2018

I was thinking mostly of user pages, for example https://www.twitch.tv/valkia/videos/all, where the newest VoD on the page is incomplete because it's for a stream that is live now.

@dstftw dstftw reopened this Apr 24, 2018
@dstftw dstftw closed this in 0ff51ad Apr 24, 2018
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Apr 24, 2018

Will work in the next version.

@chrisgavin
Copy link
Contributor Author

@chrisgavin chrisgavin commented Apr 24, 2018

Awesome, thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.