Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Better handling for partially recorded Twitch videos. #16259
Comments
|
Ah, awesome. It's good to know there's a known way to implement it. So I should just fix the Twitch extractor so it sets the |
|
This will skip all live streams like https://www.twitch.tv/paradoxinteractive. I don't know whether this will work in your case - you did not provide any example URL. |
|
I was thinking mostly of user pages, for example |
|
Will work in the next version. |
|
Awesome, thanks so much. |
Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2018.04.16. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
Description of your issue, suggested solution and other information
When using youtube-dl to archive a particular Twitch channel, if the channel is currently broadcasting you will only obtain a partial recording of the current broadcast. This partial recording is recorded in the download archive the same way as any other recording, therefore it will never be updated, even when the full recording becomes available.
Not downloading partially recorded videos is actually quite easy, the JSON response from the Twitch API lists the video as
"status": "recording", so I'm mostly opening this issue as a discussion on how this should be implemented. Should there just be a flag to not download partial recordings (or should it even be the default when downloading a playlist/channel)? Should they be downloaded, but recorded differently in the download archive so a complete copy will still be downloaded when it is ready? I'd be very interested to hear what more experienced youtube-dl developers think.