Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed thumbnail in post-processed file, instead of refusing due to original filetype #16360

Closed
qwertystop opened this issue May 2, 2018 · 1 comment

Comments

@qwertystop
Copy link

@qwertystop qwertystop commented May 2, 2018

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.05.01. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.05.01

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

When downloading a video for audio extraction with cover/thumbnail embedding, youtube-dl fails to embed a cover image when the downloaded file is not mp3, m4a, or mp4, even if the extracted audio file would be.

Sample command and output:

youtube-dl -o "./newglitch/%(autonumber)s - %(title)s.%(ext)s" -f bestaudio/best --audio-format mp3 --audio-quality 0 --add-metadata --autonumber-start 181 --write-thumbnail --sleep-interval 1 --embed-thumbnail --playlist-start 1 --playlist-end 10 --playlist-reverse "https://www.youtube.com/playlist?list=PL9793A30C55CED7F6"
[youtube:playlist] PL9793A30C55CED7F6: Downloading webpage
[download] Downloading playlist: Video Game Remixes ♫
[youtube:playlist] playlist Video Game Remixes ♫: Downloading 10 videos
[download] Downloading video 1 of 10
[youtube] _hTU9u-DK1g: Downloading webpage
[youtube] _hTU9u-DK1g: Downloading video info webpage
[youtube] _hTU9u-DK1g: Extracting video information
[youtube] _hTU9u-DK1g: Downloading thumbnail ...
[youtube] _hTU9u-DK1g: Writing thumbnail to: ./newglitch/00181 - Red and Blue Lavender Town Remix v.II.jpg
[download] Sleeping 1 seconds...
[download] Destination: ./newglitch/00181 - Red and Blue Lavender Town Remix v.II.webm
[download] 100% of 4.18MiB in 00:01
[ffmpeg] Adding metadata to './newglitch/00181 - Red and Blue Lavender Town Remix v.II.webm'
ERROR: Only mp3 and m4a/mp4 are supported for thumbnail embedding for now.

In this case, the format selector bestaudio/best chose webm, and youtube-dl refuses to embed a thumbnail in webm, where the expected/useful action would be to extract the audio into the requested mp3 format, then embed the thumbnail in that.

@qwertystop
Copy link
Author

@qwertystop qwertystop commented May 2, 2018

Cancel this. I had a typo in my command; I forgot to include -x. My sincerest apologies for wasting your time.

@qwertystop qwertystop closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.