Skip to content

/ youtube-dl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Python2 we are not checking SSL certificates on download #1672

Open
FiloSottile opened this issue Oct 28, 2013 · 2 comments
Open

In Python2 we are not checking SSL certificates on download #1672

FiloSottile opened this issue Oct 28, 2013 · 2 comments
Labels
bug

Comments

@FiloSottile
Copy link
Collaborator

@FiloSottile FiloSottile commented Oct 28, 2013

Noticed this when we were downloading the Instagram video with the misconfigured SSL cert fine everywhere except py3
@phihag
Copy link
Contributor

@phihag phihag commented Oct 28, 2013

The SSL match_hostname function is not in 2.x, so we need a backport (like this one).
@FiloSottile
Copy link
Collaborator Author

@FiloSottile FiloSottile commented Oct 28, 2013

And also to find the correct position of the CA certs

Impl. ref: https://gist.github.com/schlamar/2993700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@phihag @FiloSottile
You can’t perform that action at this time.