Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
--max-quality not being honored #168
Comments
|
The video you linked to is only available in the formats 43 (webm, 640x360), 18 (mp4, 640x360) and 5 (flv, 400x240). Since 38 is the best possible possible format (mp4, 4096x3072), However, since multiple people seem to have problems with webm and there is no discernible difference between webm and the corresponding mp4 format, the just released version 2011.09.18c ( Note that webm is still being actively developed, and is free - in the sense of free speech as well as free beer. If an open-source software does not support it, letting them now of the problem is a good idea. |
|
@VxJasonxV reopen? Just comment here why you want it reopened, and I'll reopen it. Open/closed is just a marker ;) |
|
Sorry about that. I thought that if I couldn't reopen it, I also couldn't comment. Then I tried anyways and saw that I could at least comment :P. Here's what I was going to say originally: Thanks Philipp, a few clarifying details;
Considering the output of the
Considering that we can either pick a specific format, or just specify a max format, I feel that my original understanding is exactly how it should to work, with the fallback being your suggestion of multiple format codes.
|
|
highest quality format to download means exactly that. The option is meant to limit bandwidth, not to exclude specific formats. Note that you don't have to use format fallback now to avoid webm - with 2011.09.18c (and youtube always encoding both webm and mp4 if the quality is available), you'll always get mp4 over webm. Since bug reports here are just the tip of the iceberg, and we've had two after switching to webm (which was a user suggestion from the debian project, by the way), I do think preferring mp4 is the right choice for now. With the recently introduced fallback option (which we might extend in the future), everyone can express their preferences anyways. |
|
Oh, darn... The webm format file reverted... :-( It seems like VxJasonxV is a user of a Mac and, of course, Apple only sees what they want (H.264). Anyway, thanks phihag for including that commit. I guess that I will still include that when I create the next package for Debian... :-( |
|
@rbrito Sorry, while I see the merits of webm, it seems our users want mp4. Two bug reports in such a short period is definitely too many, so I'll have to be pragmatic. Since one can assume the debian packages will only be used on debian (for debian = debian, Ubuntu, Knoppix, etc) where webm support should be at least as good as mp4 support, preferring webm is the best choice for debian. In the long term, we'll probably have configuration files, and maybe an option prefer-webm which you then could preconfigure to true in
|
|
@phihag Yes, yes. Whenever I upload a new version of youtube-dl, it does enter all those Debian-derivatives and having support for them will be nice for those that prefer something Free'er. Until we have such preference system in place, I will keep my branch OK, I know that this is getting off-topic, but just so it gets registered, I am planning on improving that vimeo support and getting support for other (external) downloaders in place. My main interest is in getting Thanks. |
|
@rbrito I'm sorry, but I don't watch all the forks of youtube-dl, but I'm looking forward to the pull request. |
I don't care much for WebM. It doesn't work in my workflow, it doesn't work in my apps, I don't want it. So, I've tried using the --max-quality flag in order to only get the best possible mp4 file, or perhaps flv (which is terrible, but acceptible).
According to http://en.wikipedia.org/wiki/YouTube#Quality_and_codecs , I should define --max-quality at 38, in order to get the best possible MP4/h.264, but no-WebM.
Unfortunately, it doesn't seem to work. Consider the following output:
Note that I have aliased 'youtube-dl' to 'youtube-dl --max-quality=38' in my .bashrc
You can see that the alias is being automatically applied (last line), but you can also see that a webm file is being downloaded (5th line).