Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment link after successful download with --batch-file #16837

Closed
OhNiice opened this issue Jun 27, 2018 · 2 comments
Closed

Comment link after successful download with --batch-file #16837

OhNiice opened this issue Jun 27, 2018 · 2 comments

Comments

@OhNiice
Copy link

@OhNiice OhNiice commented Jun 27, 2018

  • I've verified and I assure that I'm running youtube-dl 2018.06.25

  • At least skimmed through the README, most notably the FAQ and BUGS sections

  • Searched the bugtracker for similar issues including closed ones

  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Feature request (request for a new functionality)

Hi!

I read the doc, especially the Options part, and I'd like to make a request for a new option which I think shouldn't be a default behavior.

The new option would be to automatically add a comment character # ; ] to a batch download link after a (un?)successful download. In the case some links can't download and you absolutely want the whole list (using until ... do), youtube-dl wouldn't have to iterate over the whole batch file again and again.

Some pseudocode will make it more understandable hopefully :

for link in batchFile
    ...
    downloadVideo(link)
    ...
    if options.comment_link_after_successful_batch_download and link.isDownloadedSuccessfully
        newLink = '#' + link
        replaceInFile(batchFile, link, newLink)
    endif
endfor
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jun 27, 2018

Duplicate of #557.

@dstftw dstftw closed this Jun 27, 2018
@OhNiice
Copy link
Author

@OhNiice OhNiice commented Jun 28, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.