Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create --max-actual-downloads #1686

Open
viktorlindgren opened this issue Oct 30, 2013 · 4 comments
Open

Create --max-actual-downloads #1686

viktorlindgren opened this issue Oct 30, 2013 · 4 comments
Labels

Comments

@viktorlindgren
Copy link

@viktorlindgren viktorlindgren commented Oct 30, 2013

Hi

The --max-downloads does not care about if the video has been downloaded now or not.
For backwardcompability it is better to create a new option rather then change.

In YoutubeDL.py line 546 should be moved to line 694 instead if the new option is active.

https://github.com/rg3/youtube-dl/blob/7193498811cb17a66ca57569a8588adb28ba2b27/youtube_dl/YoutubeDL.py#L546

https://github.com/rg3/youtube-dl/blob/7193498811cb17a66ca57569a8588adb28ba2b27/youtube_dl/YoutubeDL.py#L694
with same indention as Line 695

@phihag
Copy link
Contributor

@phihag phihag commented Oct 30, 2013

What's the use case for this option? I'm not even certain what --max-downloads is used for.

@viktorlindgren
Copy link
Author

@viktorlindgren viktorlindgren commented Oct 31, 2013

Hi

In my scenario I don't want to download to many videos as I have very little storage space. Therefore limiting the numbers of downloads when downloading from a playlist is needed.

@phihag
Copy link
Contributor

@phihag phihag commented Oct 31, 2013

But wouldn't it be much better to specify the size of the free disk space (or even gather that automatically)? If I have 10G free space, I'd be fine with downloading a hundred short video ads, but wouldn't want two gigantic 8GB-a-piece videos.

By the way, if you want to limit the number of items you download from a playlist, you can simply use --playlist-end.

@viktorlindgren
Copy link
Author

@viktorlindgren viktorlindgren commented Oct 31, 2013

A storage option here can also work. Maybe even better but requires a little bit more of work to code.

--playlist-end counts entries also. The bad part with that is if the playlist change. I use --match-title to pick my videos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.