Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command returns before completing #16978

Closed
cog-videogames opened this issue Jul 15, 2018 · 1 comment
Closed

Update command returns before completing #16978

cog-videogames opened this issue Jul 15, 2018 · 1 comment

Comments

@cog-videogames
Copy link

@cog-videogames cog-videogames commented Jul 15, 2018

  • I've verified and I assure that I'm running youtube-dl 2018.07.10
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)

Description of your issue, suggested solution and other information

I have a wrapper script that ensures yt-dl is up to date, which does the following on start (once per week):

echo 'Checking for update...'
youtube-dl --update

echo 'Ensure update is actually complete...'
sleep 10

echo 'Continuing...'

I do this because the --update command returns too soon. Here is the latest example:

Checking for update...
Updating to version 2018.07.10 ...
Waiting for file handle to be closed ...
Ensure update is actually complete...        # Note that this line
Updated youtube-dl to version 2018.07.10.    # is before this one!
Continuing...

It would be nice if the yt-dl update command waited until it was done before exiting.
Presumably some forked-off process is finishing the job?

This has been reproducible over many updates. Windows 7 on MINGW64 bash.

Apologies if this is already filed; as you can imagine searching for update issues is rough.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jul 15, 2018

That's not possible since youtube-dl.exe is already terminated when this message is printed from a batch file running in background.

@dstftw dstftw closed this Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.