Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRKTVSeries] Download all seasons from a series broken #17159

Closed
forthrin opened this issue Aug 5, 2018 · 4 comments
Closed

[NRKTVSeries] Download all seasons from a series broken #17159

forthrin opened this issue Aug 5, 2018 · 4 comments

Comments

@forthrin
Copy link

@forthrin forthrin commented Aug 5, 2018

  • I've verified and I assure that I'm running youtube-dl 2018.08.04
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
  • Bug report (encountered problems with youtube-dl)

Downloading all seasons from a series on NRK is broken, despite the similar #16941 being fixed.

$ youtube-dl --verbose --yes-playlist https://tv.nrk.no/serie/zombielars
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'--yes-playlist', u'https://tv.nrk.no/serie/zombielars']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.08.04
[debug] Python version 2.7.15 (CPython) - Darwin-16.7.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.0.1, ffprobe 4.0.1, rtmpdump 2.4
[debug] Proxy map: {}
[NRKTVSeries] zombielars: Downloading webpage
[download] Downloading playlist: NRK TV – ZombieLars
[NRKTVSeries] playlist NRK TV – ZombieLars: Collected 0 video ids (downloading 0 of them)
[download] Finished downloading playlist: NRK TV – ZombieLars
@forthrin forthrin changed the title [NRKTVSeries] Unable to download playlist from tv.nrk.no [NRKTVSeries] Downloading all seasons from a series broken Aug 16, 2018
@forthrin forthrin changed the title [NRKTVSeries] Downloading all seasons from a series broken [NRKTVSeries] Download all seasons from a series broken Aug 16, 2018
@forthrin
Copy link
Author

@forthrin forthrin commented Aug 17, 2018

Will be resolved by committing patch in #17258.

@ralin3
Copy link

@ralin3 ralin3 commented Sep 30, 2018

Can that patch be submitted as a pull request perhaps? No point leaving it in a Issue somewhere.
I see that #17258 is another issue you created, this should be a pull request, yes?

@forthrin
Copy link
Author

@forthrin forthrin commented Oct 1, 2018

@ralin3: I'm not too up to speed on submitting pull requests. That's why I put the fix in the issue as a simple paste. Hope it's still useful. It should resolve the issue.

@sulark
Copy link

@sulark sulark commented Oct 4, 2018

@ralin3: I'm not too up to speed on submitting pull requests. That's why I put the fix in the issue as a simple paste. Hope it's still useful. It should resolve the issue.

See #17258 I added a comment there.
I really appreciate the patch, its working for series without partial episodes that has expired, but it stops for the first error and stop downloading episodes that actually are available.

Do you think you could have a look at it? Maybe something simple to get the script to jump to the next episode?

@dstftw dstftw closed this in 15699ec Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.