Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[brightcove] Crash at space.com for a brightcove video #1718

Closed
jayseye opened this issue Nov 4, 2013 · 10 comments
Closed

[brightcove] Crash at space.com for a brightcove video #1718

jayseye opened this issue Nov 4, 2013 · 10 comments
Assignees

Comments

@jayseye
Copy link

@jayseye jayseye commented Nov 4, 2013

Command line:

youtube-dl http://www.space.com/23373-huge-martian-landforms-detail-revealed-by-european-probe-video.html

Traceback output:

WARNING: Falling back on generic information extractor.
[generic] 23373-huge-martian-landforms-detail-revealed-by-european-probe-video.html: Downloading webpage
[generic] 23373-huge-martian-landforms-detail-revealed-by-european-probe-video.html: Extracting information
[generic] Brightcove video detected.
Traceback (most recent call last):
File "/usr/lib/python2.6/runpy.py", line 122, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.6/runpy.py", line 34, in _run_code
exec code in run_globals
File "/usr/bin/youtube-dl/main.py", line 18, in
File "/usr/bin/youtube-dl/youtube_dl/init.py", line 766, in main
File "/usr/bin/youtube-dl/youtube_dl/init.py", line 719, in _real_main
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 715, in download
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 363, in extract_info
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 395, in process_ie_result
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 348, in extract_info
File "/usr/bin/youtube-dl/youtube_dl/extractor/common.py", line 125, in extract
File "/usr/bin/youtube-dl/youtube_dl/extractor/brightcove.py", line 83, in _real_extract
KeyError: 'playerKey'

@canavan
Copy link

@canavan canavan commented Nov 5, 2013

Looks like a duplicate of #1697

@jayseye
Copy link
Author

@jayseye jayseye commented Nov 5, 2013

Might be a duplicate, though there has yet to be any response to that issue.

@ghost ghost assigned jaimeMF Nov 6, 2013
@jaimeMF jaimeMF closed this in 0654729 Nov 6, 2013
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Nov 6, 2013

It's fixed now, thanks for the report!
@canavan The error message is the same, but this required some further improvements.

@jayseye
Copy link
Author

@jayseye jayseye commented Nov 6, 2013

Now getting a different error (rather than a crash), KeyError: 'playerKey'. Should I file another issue, or can you reopen this one? Thanks for the help either way! Here's the full report, for the same command line:

WARNING: Falling back on generic information extractor.
[generic] 23373-huge-martian-landforms-detail-revealed-by-european-probe-video.html: Downloading webpage
[generic] 23373-huge-martian-landforms-detail-revealed-by-european-probe-video.html: Extracting information
[generic] Brightcove video detected.
Traceback (most recent call last):
File "/usr/lib/python2.6/runpy.py", line 122, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib/python2.6/runpy.py", line 34, in _run_code
exec code in run_globals
File "/usr/bin/youtube-dl/main.py", line 18, in
File "/usr/bin/youtube-dl/youtube_dl/init.py", line 766, in main
File "/usr/bin/youtube-dl/youtube_dl/init.py", line 719, in _real_main
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 715, in download
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 363, in extract_info
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 395, in process_ie_result
File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 348, in extract_info
File "/usr/bin/youtube-dl/youtube_dl/extractor/common.py", line 125, in extract
File "/usr/bin/youtube-dl/youtube_dl/extractor/brightcove.py", line 83, in _real_extract
KeyError: 'playerKey'

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Nov 6, 2013

It's fixed only in the repo, if you want to use it before a new version is released you'll have to get the source and build it with make youtube-dl (then you can do make install or copy the executable somewhere in your path), or run it with python -m youtube_dl.

@jayseye
Copy link
Author

@jayseye jayseye commented Nov 6, 2013

OK, thanks for the quick reply. I had updated to today's version, after which the Traceback crash had been replaced by an error message. So I assumed that the fix had been applied. Sorry about that. Just FYI I also commented on the commit, as it seemed unclear whether comments would be read here after this issues was closed. Just learning the ropes of this project, and as a developer myself, hope to be able to contribute at some point.

@jayseye
Copy link
Author

@jayseye jayseye commented Nov 6, 2013

Thanks https://github.com/canavan for opening the new issue. I deleted the comment which I'd previously added to the commit, based on the comment above from https://github.com/jaimeMF

In any case I'll watch both here and at #1732

@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Nov 6, 2013

We get notified of every new comment in any issue in the notifications page, and we recieved also an email if we've comment in the issue. We may miss some message, but we try to read all.
We'll appreciate any of your contributions: whether it is a issue report or a code contribution.

@phihag
Copy link
Contributor

@phihag phihag commented Nov 6, 2013

This error has been fixed in youtube-dl v2013.11.06.1. Type sudo youtube-dl -U to update.

@jayseye
Copy link
Author

@jayseye jayseye commented Nov 6, 2013

Confirming the fix. Thanks again for the quick responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.