Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimeo embed-only error message is unhelpful #17209

Closed
sramsay64 opened this issue Aug 11, 2018 · 6 comments
Closed

vimeo embed-only error message is unhelpful #17209

sramsay64 opened this issue Aug 11, 2018 · 6 comments

Comments

@sramsay64
Copy link

@sramsay64 sramsay64 commented Aug 11, 2018

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.08.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.08.04

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


When downloading a video from vimeo that can only be viewed when embedded in a page youtube-dl tells me to provide it the embedding url. But it doesn't say how. It should tell me that I need to use the --referer option but instead I have to google this every time.

I think this section in vimeo.py should be changed to:

                        'Cannot download embed-only video without embedding '
                        'URL. Please call youtube-dl with the URL of the page '
                        'that embeds this video using the --referer option.',

or something that includes --referer somewhere, so users know how to follow the instructions given.

(e.g. "https://player.vimeo.com/video/273870088" in "https://www.publicchristianity.org/episode-1-war-peace-guided-tour/#oldTestament")

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Aug 11, 2018

I wonder how you even read it. It clearly tells you to "call youtube-dl with the URL of the page that embeds this video", like youtube-dl https://www.publicchristianity.org/episode-1-war-peace-guided-tour/#oldTestament.

@dstftw dstftw closed this Aug 11, 2018
@sramsay64
Copy link
Author

@sramsay64 sramsay64 commented Aug 11, 2018

That downloads all 11 videos from the page. The command that downloads only the video I told it to download (and the only one I wanted) is youtube-dl "https://player.vimeo.com/video/273870088" --referer "https://www.publicchristianity.org/episode-1-war-peace-guided-tour/#oldTestament". If I use your command I get 10 extra videos that I didn't want (and no indication of which video is the one that I asked for).

Let me clarify why I read it wrong. In the past I've downloaded videos this way (supplying 2 urls) so I knew that such a thing was possible. And I didn't know this video was embed only until I got the error message from running youtube-dl "https://player.vimeo.com/video/273870088". So I knew there was an option but not what it was. Still even if I did follow it literally, I only wanted to download one of the videos

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Aug 11, 2018

Passing or not passing referer is an implementation detail that should be handled internally by youtube-dl. Today passing referer works tomorrow it will require passing some additional headers/cookies/wahtever making using --referer alone useless. On the other hand when you pass the original URL youtube-dl handles this all implicitly. So I won't add such implementation specific messages that may become outdated.

@dstftw dstftw reopened this Aug 11, 2018
@dstftw dstftw closed this Aug 11, 2018
@sramsay64
Copy link
Author

@sramsay64 sramsay64 commented Aug 11, 2018

Yeah, I thought it would be a quick fix. I didn't realise that the implementation is quite complicated.

@JohnVillalovos

This comment was marked as off-topic.

@stordoff

This comment was marked as off-topic.

@ytdl-org ytdl-org locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.