Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
report_destination before sleeping #17301
Comments
|
No such change will be accepted since downloaders may output arbitrary messages (like |
|
Ok how about changing output slightly from [download] Sleeping 11.85 seconds... to [download] Sleeping 11.85 seconds for info_dict['title'] ... |
|
I won't do any adjustments just to fit some particular case. If you want to get title before downloading then you have to separate info extraction and actual downloading or even handle downloading on your own. |
|
But info_dict and filename are already available at that stage. There is no need to change anything. I am just requesting to be more verbose in output. In any case, thank you for your prompt replies. |
|
Then use it. I've already pointed out how you should do that. And again: I'm not going to do any verbosity changes just to fit your concrete case. You want "sleeping X seconds for filename", someone may want to have "sleeping Y seconds for filesize video", someone may already rely on current wording. This output is not supposed to be used as source of metadata. For metadata you have info dict that you must use. |
Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2018.08.22. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
Description of your issue, suggested solution and other information
This is minor enhancement request when downloading playlist videos with sleep between 2 downloads, using --sleep-interval / --max-sleep-interval
youtube-dl first sleeps and then prints the name of the file (which is more or less title of the video)
[download] Sleeping 11.85 seconds...
[download] Destination: some_title.webm
Sometimes sleeps are more than 30-45 seconds and I have to wait to find out which video its going to download next.
I request to rearrange this a bit ... first print the filename and then sleep.
[download] Destination: some_title.webm
[download] Sleeping 11.85 seconds...
This can be achieved by calling self.report_destination(filename) inside download() function of common.py.. i.e. just before sleep call which happens just before real_download() function call.
This will also eliminate report_destination(filename) lines located inside many "downloaders". And instead bring it to one single place. (common.py)
I can create a PR if developer wants.