Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arte.tv format code is not unique #1739

Closed
Cigaes opened this issue Nov 8, 2013 · 2 comments
Closed

arte.tv format code is not unique #1739

Cigaes opened this issue Nov 8, 2013 · 2 comments
Labels
bug

Comments

@Cigaes
Copy link

@Cigaes Cigaes commented Nov 8, 2013

./youtube-dl --list-formats http://www.arte.tv/guide/fr/047910-003/top-of-the-lake-3-6
[arte.tv:+7] 047910-003: Downloading webpage
[arte.tv:+7] 047910-003: Downloading info json
[arte.tv:+7] 047910-003: Extracting information
[info] Available formats for 047910-003_PLUS7-F:
format code    extension resolution  note
220-VF-STF     flv       320x200     VF (worst)
220-VO-STF     flv       320x200     VOSTF
220-VF-STMF    flv       320x200     ST sourds/mal
400-VF-STF     mp4       640x360     VF
400-VO-STF     mp4       640x360     VOSTF
400-VF-STMF    mp4       640x360     ST sourds/mal
400-VO-STF     flv       720x406     VOSTF
400-VF-STF     flv       720x406     VF
400-VF-STF     flv       720x406     VF
400-VF-STMF    flv       720x406     ST sourds/mal
400-VF-STMF    flv       720x406     ST sourds/mal
400-VO-STF     flv       720x406     VOSTF
720-VF-STF     flv       1280x720    VF
720-VO-STF     flv       1280x720    VOSTF
720-VF-STMF    flv       1280x720    ST sourds/mal (best)

You can notice that the 400-* codes appear each three times, once for 640×360 mp4 and twice for 720×406 flv (they differ in bitrate: 800 and 1500 announced IIRC).

Suggested fix: include the bitrate in the format code:

format_id = u'%s-%s-%s' % (quality, format_info['bitrate'], format_info['versionCode'])

By the way, thanks a lot for implementing the format selection feature!

@jaimeMF jaimeMF closed this in 566d4e0 Nov 9, 2013
@jaimeMF
Copy link
Collaborator

@jaimeMF jaimeMF commented Nov 9, 2013

Fixed, thanks for the report.

@Cigaes
Copy link
Author

@Cigaes Cigaes commented Nov 9, 2013

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.