Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for ffmpeg twice #17416

Closed
zaza42 opened this issue Sep 2, 2018 · 2 comments
Closed

Checking for ffmpeg twice #17416

zaza42 opened this issue Sep 2, 2018 · 2 comments
Labels

Comments

@zaza42
Copy link

@zaza42 zaza42 commented Sep 2, 2018

  • I've verified and I assure that I'm running youtube-dl 2018.09.01

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

When running youtube-dl (without any parameters) it always checks ffmpeg and ffprobe versions twice.

07:10:23.367241     25388 /usr/bin/python /usr/local/bin/youtube-dl
07:10:23.459397       25389 /sbin/ldconfig -p
07:10:23.549655       25390 stty size
07:10:23.582957       25393 ffmpeg -version
07:10:23.634771       25394 ffprobe -version
07:10:23.687911       25397 ffmpeg -version
07:10:23.734922       25398 ffprobe -version

I think it's useless to check versions of binaries twice.
I'd be happy with a --force-ffmpeg-version=4.0.2 parameter, for skip checking binaries on every run. (I run a dozens of youtube-dl per one second)

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Sep 2, 2018

If you run it without any parameters it should not check anything. If you run it with -v it will check each executable once for debug output. It may output it twice due to avconv/avprobe symlinked to ffmpeg counterparts on your OS. Read issue template and provide complete verbose log along with strace output.

@dstftw dstftw closed this Sep 2, 2018
@dstftw dstftw added the incomplete label Sep 2, 2018
@zaza42
Copy link
Author

@zaza42 zaza42 commented Sep 3, 2018

Ok, i have a /etc/youtube-dl.conf which contains
--add-metadata --embed-thumbnail
parameters. Each of them checking for ffmpeg once. Can it be one check at all? Or no check at all with a parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.