Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Don't download webpage if video identifier matches in archive file #17504

Closed
mjolnir870 opened this issue Sep 9, 2018 · 4 comments
Closed

Comments

@mjolnir870
Copy link

@mjolnir870 mjolnir870 commented Sep 9, 2018

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.09.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.09.08

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

When using the --download-archive feature youtube-dl still downloads each video's webpage. After downloading, the video is skipped based off the identifier that youtube-dl already has from the initial link.

Can this process be changed so that youtube-dl will discard the video as soon as the identifier is matched from the URL? Doing it this way will allow downloads to complete much faster since youtube-dl doesn't have to download potentially hundreds of webpages for a large playlist. The bigger return on this is that it also avoids slamming a video site with hundreds of page requests that are eventually discarded.

Current process:

  1. youtube-dl has video with identifier ABCD
  2. youtube-dl downloads webpage for video ABCD
  3. youtube-dl aborts download of video ABCD since it matches in archive file

Requested process:

  1. youtube-dl has video with identifier ABCD
  2. youtube-dl aborts download of video ABCD since it matches in archive file
@mjolnir870 mjolnir870 changed the title [Request] Don't download webpage if video key matches in archive file [Request] Don't download webpage if video identifier matches in archive file Sep 9, 2018
@dstftw
Copy link
Collaborator

@dstftw dstftw commented Sep 9, 2018

This depends on a particular extractor. It does discard as soon as possible if video id is known beforehand and extractor supports it.

@dstftw dstftw closed this Sep 9, 2018
@mjolnir870
Copy link
Author

@mjolnir870 mjolnir870 commented Sep 11, 2018

Can this be reopened and then specifically be a request for the pornhub extractor to support this then? The video URL provides the identifier but the pornhub extractor is still downloading the webpage.

@mjolnir870
Copy link
Author

@mjolnir870 mjolnir870 commented Sep 13, 2018

Should I open a new issue instead of requesting that this one be reopened?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Sep 13, 2018

Open a new issue with complete explanation regarding concrete extractor.

@ytdl-org ytdl-org locked and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.