Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisplayWidth and DisplayHeight to Format Selection (-f) #17951

Open
hl2guide opened this issue Oct 23, 2018 · 4 comments
Open

Add DisplayWidth and DisplayHeight to Format Selection (-f) #17951

hl2guide opened this issue Oct 23, 2018 · 4 comments

Comments

@hl2guide
Copy link

@hl2guide hl2guide commented Oct 23, 2018

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.05. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.10.05

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2018.10.05
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.


Description of your issue, suggested solution and other information

Please consider adding a useful feature for "displaywidth" and "displayheight" for the format selection (-f switch). Being the width and height of the current display in pixels.

This would allow something like:
-f "bestvideo[height<=displayheight]+bestaudio/best[height<=displayheight]"

@hl2guide hl2guide changed the title Add DisplayWidth and DisplayWidth to Format Selection (-f) Add DisplayWidth and DisplayHeight to Format Selection (-f) Oct 23, 2018
@VietTPham
Copy link
Contributor

@VietTPham VietTPham commented Oct 26, 2018

I thought there's already that option, that is straight from the readme https://github.com/rg3/youtube-dl/blob/master/README.md

width (numeric): Width of the video
height (numeric): Height of the video

Download best format available but not better that 480p
$ youtube-dl -f 'bestvideo[height<=480]+bestaudio/best[height<=480]'

@rautamiekka
Copy link

@rautamiekka rautamiekka commented Oct 26, 2018

If you're meaning the resolution at which it's shown when viewed when the vid's resolution is lower than your screen's, that's not possible, it's all done automatically by the browser as a compensation.

@hl2guide
Copy link
Author

@hl2guide hl2guide commented Oct 27, 2018

hmmm, not quite what I mean.
For example my native resolution for my monitor is 1920x1080 (1080p).

I can use -f "bestvideo[height<=1080]+bestaudio/best[height<=1080]" and that makes sure that I only get up to 1080p videos, not 4K.

To be clear I am talking about the width and height of the display, not the video itself.

A variable that exposes the monitor dimensions would be useful 💃

@VietTPham
Copy link
Contributor

@VietTPham VietTPham commented Oct 27, 2018

does not sense to spend time adding this as a feature, you can just use another program that get your screen resolution, and add it as a variable to youtube-dl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.