Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
ASS subs converted to mov_text with --embed-subs #17968
Comments
|
you can use this command to change container of the mp4 to mkv without converting |
|
I know. Is there a way to get youtube-dl to do it for me, though? I already have a one-click download setup that works for everything except styled subs. Why isn't there an option to output everything as mkv by default? |
|
maybe this then |
Same output. |
|
Yes, it should be enabled by default output .mkv |
|
Soft subs can be embedded in MP4. The ass subs need to be converted in to a sub format compatible with with quictime pro. There is a funimation program on a get repository that will add tx3g softsubs to an mp4. Have tested a file on my apple device. Text |
|
@darkhelmet2016 yes, but having timed_text sub format for anime is not suitable as many videos have multiple subtitle layers involved, and they can be perfectly placed using ASS. However, timed text sacrifices one of those layers and displays everything as one (the main subtitles). The only way I have found to include crunchyroll subs is by doing a |
|
You have to do no such thing. --sub-lang enUS --write-sub --convert-subs srt --embed-subs works for Crunchyroll. This will give an mp4 with srt subs. Have used this on a front end program. -o ".\videoDownloads%(title)s-%(id)s-%(height)sp.%(ext)s" --add-metadata --sub-lang enUS --write-sub --convert-subs srt --embed-subs This is if you want mp4 with sub output. ffmpeg converts the ass subs from the crunchy site to srt. If you just want .ass subs to mux in then don't have them added to the file and just use mkv merge to mux the mp4 file. Just have it write but not embed or covert subs if you need .ass and it will write the subs from the site and output it to where you tell it. http://ffmpeg.org/documentation.html Or are you looking for actual hard subs imprinted in to the video? |
|
@darkhelmet2016 Nope, even when I did do
i ran this command |
|
I just want to embed subs within the video, not burn them in. The problem with embedding Timed Text subs is that sometimes during multiple conversations in anime the subs are mixed together and gets really confusing for the viewer to understand |
|
That is because mov_text is timed text which is what the thread was looking for. Like said if you just want ass subs do not embed them but leave them as a separate file and open up mkv merge and mux the ass subs with the video audio. What episode are you trying to get? https://github.com/seiya-dev/crunchyroll-downloader-nx will download crunchy videos in mkv with ass sub and keep what styling is in the dumb subs. If the program you are using does not decrypt the subs right it will not matter what you use. It has to be able to decrypt the subs using the proper styling libs or what ever is compiled to keep sub formatting. |
|
@darkhelmet2016 thanks you for the link! that was exactly what I wanted. |
|
NP. but with srt you are going to be limited what you can do anyway, or you can open them in a program that will give you srt but will still wind up with something like this. 1 2 3 4 5 6 7 8 http://www.aegisub.org/ will do sub conversion too. ffmpeg would need to be compiled with libass think the program is to even do subs properly from crunchy. A lot of downloaders for the site use some kind of lb package from python to java. |
|
ahh, i guess embedding ASS is the only option then |
|
Sadly srt is more for things like closed caption subbing or basic subs with min formatting. You can try messing with aegisub and see what it will keep as srt output. |
|
crunchy is working perfectly, worked straight off the bat. I might contribute some to the project like adding more customization regarding output/renaming of files, sub-lang selection, and a couple minor tweaks. |
|
Ok, just get with him since it his program. Have only been submitting bugs for it. But will keep working on this one to get a somewhat working down-loader for Crunchy. |
Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2018.10.05. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Description of your issue, suggested solution and other information
The subtitles are being converted to mov_text, likely because mp4 doesn't support soft-subs. I can't seem to find a way to force mkv output without re-encoding the video, which seems silly when it's the only output format in youtube-dl that supports soft-subs. There needs to be a way to force mkv output and properly embed the ASS subs (without re-encoding). For now I can just pass
-kto keep the ASS subs and use mkvmerge to get the desired result, but I hope youtube-dl can handle this automatically in the future.