Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crunchyroll] Dangerous ignoring of failure of downloading of m3u8 information #17998

Closed
Arfrever opened this issue Oct 28, 2018 · 1 comment
Closed

Comments

@Arfrever
Copy link

@Arfrever Arfrever commented Oct 28, 2018

I am not sure if problem is specific to Crunchyroll extractor, or more general.
I happened to reproduce this problem:

[crunchyroll] 719441: Downloading webpage
[crunchyroll] 719441: Downloading audio-jaJP m3u8 information
WARNING: Failed to download m3u8 information: <urlopen error [Errno 110] Connection timed out>
[crunchyroll] 719441: Downloading audio-jaJP-hardsub-enUS m3u8 information
[crunchyroll] 719441: Downloading media info
[info] Writing video subtitles to: ${target}.enUS.ass
[download] Destination: ${target}.mp4
ffmpeg version 4.0.2 Copyright (c) 2000-2018 the FFmpeg developers
...

This means that youtube-dl downloaded video file with hardcoded English subtitles (audio-jaJP-hardsub-enUS variant) instead of pure video file (audio-jaJP variant).

I think that it is better that youtube-dl abort downloading video file if m3u8 information for preferred format fails to be downloaded.

(Variant without hardcoded subtitles is preferred by default since commit 1084563.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.