Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dl fail] Is netease module still being maintained? #18051

Open
inkuxuan opened this issue Nov 2, 2018 · 1 comment
Open

[dl fail] Is netease module still being maintained? #18051

inkuxuan opened this issue Nov 2, 2018 · 1 comment

Comments

@inkuxuan
Copy link

@inkuxuan inkuxuan commented Nov 2, 2018

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.29. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.10.29

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Full command and output:

C:\Users\inkux\Desktop>youtube-dl https://music.163.com/#/song?id=33166366 --verbose --proxy ""
[debug] System config: []
[debug] User config: ['--proxy', 'socks5://[censored]/']
[debug] Custom config: []
[debug] Command-line args: ['https://music.163.com/#/song?id=33166366', '--verbose', '--proxy', '']
[debug] Encodings: locale cp936, fs mbcs, out cp936, pref cp936
[debug] youtube-dl version 2018.10.29
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: ffmpeg N-90414-gabf35afb6f, ffprobe N-90414-gabf35afb6f
[debug] Proxy map: {}
[netease:song] 33166366: Downloading song info
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
[netease:song] 33166366: Checking song URL
[netease:song] 33166366: song URL is invalid, skipping
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpadzwnijc\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpadzwnijc\build\youtube_dl\extractor\common.py", line 508, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpadzwnijc\build\youtube_dl\extractor\neteasemusic.py", line 164, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpadzwnijc\build\youtube_dl\extractor\common.py", line 1287, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I've noticed from the issue page that netease module had been down for quite a while in 2016, but since I got an instruction to report this and those issues are pretty aged, I decided to report it anyway.

I was downloading this song which is totally playable in my browser(Google Chrome), and is also downloadable as a mp3 file using netease client (PC, Android), of course using a Chinese IP address.

As you can see youtube-dl correctly recognized the ID of the song from its URL but has been unable to obtain any format.

And if this module is never going to be maintained for a period of time, I think it's a good idea to disable the module if it is believed it will never work again, so no one gets a bug report request when they see netease music in your support sites list and then fails to download using yt-dl, given that netease is a pretty popular music site in China.


@blackjack4494
Copy link

@blackjack4494 blackjack4494 commented Sep 9, 2020

Well there I am. Pretty late but I randomly came across this extractor.

There are changes on netease (music.163.com). They changed endpoints and have more than one now. Also their response is different.

Song (data as in m4a) related api is
https://music.163.com/weapi/song/enhance/player/url/v1?csrf_token=
song details is now
https://music.163.com/weapi/v3/song/detail?csrf_token=
and so on. if there is enough interest I can update the extractor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.