Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for viki tv #1813

Closed
seojoohyun opened this issue Nov 23, 2013 · 6 comments
Closed

support for viki tv #1813

seojoohyun opened this issue Nov 23, 2013 · 6 comments

Comments

@seojoohyun
Copy link

@seojoohyun seojoohyun commented Nov 23, 2013

Can you support for http://www.viki.com/tv be added?
Thanks.

@phihag phihag closed this in 382ed50 Nov 24, 2013
@phihag
Copy link
Contributor

@phihag phihag commented Nov 24, 2013

Thanks for the report. Support for viki has been added as of youtube-dl 2013.11.24. Type youtube-dl -U to update.

@seojoohyun
Copy link
Author

@seojoohyun seojoohyun commented Nov 24, 2013

Downloaded the latest and tried it with this URL
http://www.viki.com/videos/204388v-answer-me-1997-reply-1997-episode-1

Got this result
C:\Users\Seojohyun\Videos\ytdl>youtube-dl.py -v http://www.viki.com/videos/204388v-answer-me-1997-reply-1997-episode-1
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.viki.com/videos/204388v-answer-me-1997-r
eply-1997-episode-1']
[debug] youtube-dl version 2013.11.24.1
[debug] Python version 2.7.3 - Windows-7-6.1.7601-SP1
[debug] Proxy map: {}
[viki] 204388v: Downloading webpage
ERROR: Unable to extract uploader; please report this issue on https://yt-dl.org/bug .
Be sure to call youtube-dl with the --verbose flag and include its complete output. M
ake sure you are using the latest version; type youtube-dl -U to update.
Traceback (most recent call last):
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\YoutubeDL.py", line 416, in
extract_info
ie_result = ie.extract(url)
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\common.py", line
129, in extract
return self._real_extract(url)
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\viki.py", line 37
, in _real_extract
u'uploader')
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\common.py", line
286, in _html_search_regex
res = self._search_regex(pattern, string, name, default, fatal, flags)
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\common.py", line
276, in _search_regex
raise RegexNotFoundError(u'Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract uploader; please report this issue on https://yt
-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its compl
ete output. Make sure you are using the latest version; type youtube-dl -U to update
.

@phihag
Copy link
Contributor

@phihag phihag commented Nov 25, 2013

On that video, I see an error message Video is Unavailable, so I can't test it. However, I've fixed the bug you've seen by making the uploader field optional. Can you retry with youtube-dl 2013.11.25?

@seojoohyun
Copy link
Author

@seojoohyun seojoohyun commented Nov 25, 2013

Download is working now, thanks.
Subtitles don't seem to be working though. I tried --write-srt, --write-sub, and -list-subs, all gave similar results.

C:\Users\Seojoohyun\Videos\ytdl>youtube-dl.py --write-srt --skip-download -v http://www.viki.com/videos/204388v-answer-me-1997
-reply-1997-episode-1
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--write-srt', '--skip-download', '-v', 'http://www.viki.com/videos/204388v-answer-me-1997-r
eply-1997-episode-1']
[debug] youtube-dl version 2013.11.25
[debug] Python version 2.7.3 - Windows-7-6.1.7601-SP1
[debug] Proxy map: {}
[viki] 204388v: Downloading webpage
[viki] 204388v: Downloading info page
Traceback (most recent call last):
File "C:\Python27\lib\runpy.py", line 162, in run_module_as_main
"main", fname, loader, pkg_name)
File "C:\Python27\lib\runpy.py", line 72, in run_code
exec code in run_globals
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py__main
.py", line 18, in
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl__init__.py", line 691, in main
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl__init__.py", line 681, in _real_main
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\YoutubeDL.py", line 807, in download
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\YoutubeDL.py", line 432, in extract_info
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\common.py", line 131, in extract
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\viki.py", line 75, in _real_extract
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\subtitles.py", line 37, in extract_subtitles
File "C:\Users\Seojoohyun\Videos\ytdl\youtube-dl.py\youtube_dl\extractor\viki.py", line 94, in _get_available_subtitles
TypeError: findall() takes at least 2 arguments (1 given)

@phihag
Copy link
Contributor

@phihag phihag commented Nov 25, 2013

Oops, that's an error of mine, sorry. Fixed in youtube-dl 2013.11.25.1 .

You can use --list-subs or --write-sub now. --write-srt is deprecated and should not be used anymore.

@seojoohyun
Copy link
Author

@seojoohyun seojoohyun commented Nov 25, 2013

Awesome... thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.