Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Before submitting an issue make sure you have:
What is the purpose of your issue?
Description of your issue, suggested solution and other information
Every time we get to conversion with ffmpeg, a console window opens up for the remainder of ffmpeg's operation due to the way Windows handles new processes being spawned.
Would it be possible for an extra extra option to be passed when embedding youtube-dl, denoting that the application is graphical so that the calls to the postprocessor can go from
https://github.com/rg3/youtube-dl/blob/d19600df07128c73ef7242af7e1cd8c819951aba/youtube_dl/postprocessor/ffmpeg.py#L164
https://github.com/rg3/youtube-dl/blob/d19600df07128c73ef7242af7e1cd8c819951aba/youtube_dl/postprocessor/ffmpeg.py#L199
to
handle = subprocess.Popen(cmd, stderr=compat_subprocess_get_DEVNULL(), stdout=subprocess.PIPE, stdin=subprocess.PIPE, creationflags=0x08000000)and
p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, stdin=subprocess.PIPE, creationflags=0x08000000)respectively.
Where
0x08000000isCREATE_NO_WINDOWas per https://docs.microsoft.com/en-us/windows/desktop/procthread/process-creation-flagsThis would also require a platform check since this would only work on Windows.
I've tried this and it works , would've made a pull request but I'm not too familiar with the codebase, just managed to track down where and how ffmpeg was being called to patch it for myself.