[youtube] mtime not set when downloading in segments

[codl]

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.12.03. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

• I've verified and I assure that I'm running youtube-dl 2018.12.03

Before submitting an issue make sure you have:

• At least skimmed through the README, most notably the FAQ and BUGS sections
• Searched the bugtracker for similar issues including closed ones
• Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

• Bug report (encountered problems with youtube-dl)
• Site support request (request for adding support for a new site)
• Feature request (request for a new functionality)
• Question
• Other

---

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

[debug] System config: []
[debug] User config: ['--no-playlist', '--format', 'bestvideo[height<=1080]+bestaudio/best', '--write-sub', '--embed-subs', '--add-metadata']
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=SSlMVn3Kr7o']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.11.23
[debug] Python version 3.7.1 (CPython) - Linux-4.19.2-arch1-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg n4.1, ffprobe n4.1, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] SSlMVn3Kr7o: Downloading webpage
[youtube] SSlMVn3Kr7o: Downloading video info webpage
WARNING: video doesn't have subtitles
[youtube] SSlMVn3Kr7o: Downloading MPD manifest
[youtube] SSlMVn3Kr7o: Downloading MPD manifest
[debug] Invoking downloader on 'https://r3---sn-cv0tb0xn-gone.googlevideo.com/videoplayback/id/49294c567dcaafba/itag/298/source/youtube/requiressl/yes/mm/31,29/pl/18/ms/au,rdu/ei/I1EFXLqfMsqWowOkmLe4CQ/mn/sn-cv0tb0xn-gone,sn-25ge7nse/mv/m/initcwndbps/806250/ratebypass/yes/mime/video%2Fmp4/otfp/1/gir/yes/clen/926189583/lmt/1543240940608046/dur/3741.816/mt/1543852242/fvip/3/disable_polymer/true/ip/176.144.28.10/ipbits/0/expire/1543873924/sparams/ip,ipbits,expire,id,itag,source,requiressl,mm,pl,ms,ei,mn,mv,initcwndbps,ratebypass,mime,otfp,gir,clen,lmt,dur/signature/648C38274024FF57A99C208A8992EA7116996656.149693E2FCBBFEFA3C194EB1CDFDCB290693E97D/key/dg_yt0/'
[dashsegments] Total fragments: 740
[download] Destination: Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.f298.mp4
[download] 100% of 883.27MiB in 03:37
[debug] Invoking downloader on 'https://r3---sn-cv0tb0xn-gone.googlevideo.com/videoplayback/id/49294c567dcaafba/itag/140/source/youtube/requiressl/yes/mm/31,29/pl/18/ms/au,rdu/ei/I1EFXLqfMsqWowOkmLe4CQ/mn/sn-cv0tb0xn-gone,sn-25ge7nse/mv/m/initcwndbps/806250/ratebypass/yes/mime/audio%2Fmp4/otfp/1/gir/yes/clen/60558933/lmt/1543240990594713/dur/3741.872/mt/1543852242/fvip/3/disable_polymer/true/ip/176.144.28.10/ipbits/0/expire/1543873924/sparams/ip,ipbits,expire,id,itag,source,requiressl,mm,pl,ms,ei,mn,mv,initcwndbps,ratebypass,mime,otfp,gir,clen,lmt,dur/signature/532A0FC95FEBC816D40A539923EF5EE3E39A8207.9855DF2B9774241143241BA39BD1508959320AD1/key/dg_yt0/'
[dashsegments] Total fragments: 376
[download] Destination: Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.f140.m4a
[download] 100% of 57.75MiB in 00:44
[ffmpeg] Merging formats into "Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.mp4"
[debug] ffmpeg command line: ffmpeg -y -i 'file:Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.f298.mp4' -i 'file:Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.f140.m4a' -c copy -map 0:v:0 -map 1:a:0 'file:Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.temp.mp4'
Deleting original file Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.f298.mp4 (pass -k to keep)
Deleting original file Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.f140.m4a (pass -k to keep)
[ffmpeg] Adding metadata to 'Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.mp4'
[debug] ffmpeg command line: ffmpeg -y -i 'file:Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.mp4' -c copy -metadata 'title=Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE' -metadata date=20181126 -metadata 'description=Short unedited video on Plug Dropping: https://youtu.be/oiyKKljHgy0

My Twitch Channel: https://www.twitch.tv/xnose_

Chibi-Robo! Discord: https://discordapp.com/invite/H86kNUD

Chibi-Robo! Plug Into Adventure Speedrunning Leaderboard: https://www.speedrun.com/cr

My Discord Server: https://discordapp.com/invite/YdWUuZM

My Twitter: https://twitter.com/xNose_' -metadata 'comment=Short unedited video on Plug Dropping: https://youtu.be/oiyKKljHgy0

My Twitch Channel: https://www.twitch.tv/xnose_

Chibi-Robo! Discord: https://discordapp.com/invite/H86kNUD

Chibi-Robo! Plug Into Adventure Speedrunning Leaderboard: https://www.speedrun.com/cr

My Discord Server: https://discordapp.com/invite/YdWUuZM

My Twitter: https://twitter.com/xNose_' -metadata 'purl=https://www.youtube.com/watch?v=SSlMVn3Kr7o' -metadata artist=xNose_ 'file:Chibi-Robo! Any% Speedrunning Tutorial - Part 1 WITH VOICE-SSlMVn3Kr7o.temp.mp4'
[ffmpeg] There aren't any subtitles to embed

---

Description of your issue, suggested solution and other information

When downloading most videos, the final file's mtime is set to time the video was uploaded, but some videos — the ones that get downloaded in dash segments, i think, here's one example — don't get their mtime set and end up with an mtime of whenever it was downloaded.

[dstftw]

mtime sets time to the value of Last-Modified header not video upload time. This only works for single file HTTP downloads.

[codl]

er ok, i guess i'll post this again as a feature request then

[dotysan]

Actually, it appears the Last-Modified header does exist on each segment. All we need to do is save one for when the all segments are completely downloaded.