Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads 16:9 thumbnails from YouTube Music and uses " - Topic" uploader name #18511

Open
probablykasper opened this issue Dec 13, 2018 · 3 comments

Comments

@probablykasper
Copy link

@probablykasper probablykasper commented Dec 13, 2018

Before submitting an issue make sure you have:

  • I've verified and I assure that I'm running youtube-dl 2018.12.09
  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report, at least kind of

Downloading from YouTube Music results in a 16:9 thumbnail and an uploader name ending with - Topic.

Here's an example where I run the command youtube-dl -x --audio-format mp3 -o '%(uploader)s.%(ext)s' --embed-thumbnail https://music.youtube.com/watch?v=uRGgWKEiOHg.
The URL's page looks like this:
image
This is the thumbnail that is added to the output file:
flutter
This could be fine for a YouTube URL, but in this case the URL's page does not contain this thumbnail anywhere.
Additionally, the output file ends up with the filename Diamond Eyes - Topic.mp3. Again, this might be ok for a regular YouTube URL, but in the URL there is no sign of " - Topic" being part of the uploader's name.

@ealgase
Copy link
Contributor

@ealgase ealgase commented Dec 19, 2018

music.youtube.com is just another client for YouTube (just like gaming.youtube.com). If you check the video at https://www.youtube.com/watch?v=uRGgWKEiOHg, you'll see that both the thumbnail and uploader are correct.

@probablykasper
Copy link
Author

@probablykasper probablykasper commented Dec 19, 2018

@ealgase That's why I'm saying it's fine for YouTube URLs but not YouTube Music URLs. Either way it's not good UX

@ealgase
Copy link
Contributor

@ealgase ealgase commented Dec 19, 2018

@SpectralKH true. The way to fix this is to make a separate extractor for YouTube music, that gets the thumbnail and artist name, then sends gets the normal YouTube extractor to get the rest of the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.