Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Average_rating not behaving correctly in match_filter #18734
Comments
|
I have the same problem. In the test I am doing only one video is filtered out even though many other videos are below the rating threshold. Youtube-dl knows what the rating is but still doesn't filter correctly. I think it is only accepting integer values (flooring the rating threshold given by the user). Because the one video that it does filter out for me has a rating of 3.6. Anything at or above 4 and the filter catches it, but at 3.9 it passes through. |
|
For now a workaround could be to filter for like_count > X & dislike_count < Y. But this should be easily fixed. |
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like this:[x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2019.01.02. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the
-vflag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):Description of your issue, suggested solution and other information
Basically the average_rating parameter appears to not be working correctly, according to:
krzysztofs-macbook-pro:~ kk$ youtube-dl -o '%(title)s.%(average_rating)s.%(ext)s' "ytsearch10:ai"
5 of these videos should not be downloaded( for example last one has average_rating of 4.7812795639)