Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning/error log messages should not contain ANSI escape sequences #18917

Closed
tonycpsu opened this issue Jan 18, 2019 · 1 comment
Closed

warning/error log messages should not contain ANSI escape sequences #18917

tonycpsu opened this issue Jan 18, 2019 · 1 comment
Labels

Comments

@tonycpsu
Copy link

@tonycpsu tonycpsu commented Jan 18, 2019

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.01.17. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2019.01.17

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Description of your issue, suggested solution and other information

I am developing a console application using urwid. When youtube_dl reports errors, even with ignoreerrors=True, I'm getting output to the console, which interferes with the operation of my app.

I see in the comments to #9281 that "Logger can be used to intercept errors though it will hook all the errors not only ExtractorError." Doing this does, in fact, get the errors passed to my application's log handler, but it does so with unsightly ANSI escape codes in it:

image

My proposed solution would be to not add the WARNING/ERROR strings (and certainly not the color codes) if the user passes in their own logger.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Jan 18, 2019

--no-color.

@dstftw dstftw closed this Jan 18, 2019
@dstftw dstftw added the invalid label Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.