Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script should try and catch AtomicParsley return code 2 #18994

Open
shinji257 opened this issue Jan 25, 2019 · 0 comments
Open

Script should try and catch AtomicParsley return code 2 #18994

shinji257 opened this issue Jan 25, 2019 · 0 comments

Comments

@shinji257
Copy link

@shinji257 shinji257 commented Jan 25, 2019

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.01.24. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2019.01.24

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.01.24
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.


Description of your issue, suggested solution and other information

When attempting to use AtomicParsley on a file > 2GB (I'm making a small guess here) it errors with the message.

You must be off your block thinking I'm going to tag a file that is at LEAST 4534752061 bytes long.
AtomicParsley doesn't have full 64-bit support

I'm taking a small guess that it is limited to 32-bit right now and that would end up being right around 2GB. Currently this actually stops script. What's more it just spits out the text ERROR: in red and nothing more. I got the above by running the command directly that came up in the verbose output during debugging.

At this point the script should either catch the return code when the program is run and an attempt to embed fails or flat out limit it in the scripting and not even run it when the step comes up if the file is > 2GB. Either way the thumbnail that has already been downloaded should be left in place in case the user wants to try to embed it via another route.

Update: This seems to be version dependent. I'm on Ubuntu 16.04 and it seems the repository version is rather old. I found a forked repository that seems to be a bit more up to date and it handled the file fine.

With that said catching the return code is still a valid case to try and handle since it will indicate that the user has an older version that can't handle the larger files properly.

Ubuntu 18.04 and higher has 0.9.6 which is what I had built myself. This is what people should be using for proper support.

@shinji257 shinji257 changed the title Script should try and catch AtomicParsley return code 2 or internally restrict (filesize > 2GB) Script should try and catch AtomicParsley return code 2 Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.