Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crunchyroll] Use system locale for metadata language #19138

Closed
Atemu opened this issue Feb 5, 2019 · 2 comments
Closed

[Crunchyroll] Use system locale for metadata language #19138

Atemu opened this issue Feb 5, 2019 · 2 comments

Comments

@Atemu
Copy link

@Atemu Atemu commented Feb 5, 2019

  • I've verified and I assure that I'm running youtube-dl 2019.01.30.1

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

youtube-dl -v -e 'https://www.crunchyroll.com/a-place-further-than-the-universe/episode-1-one-mwillion-yen-for-youth-757769'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-e', 'https://www.crunchyroll.com/a-place-further-than-the-universe/episode-1-one-mwillion-yen-for-youth-757769']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.01.30.1
[debug] Python version 3.7.2 (CPython) - Linux-4.20.6-arch1-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 4.1, ffprobe 4.1, rtmpdump 2.4
[debug] Proxy map: {}
[debug] Default format spec: bestvideo+bestaudio/best
A Place Further Than the Universe Folge 1 – Die Jugend für eine Million Yen

Description of your issue, suggested solution and other information

When I download videos from Crunchyroll, the metadata like title, description etc. are all in the language based on my IP address which in my case is German.
CR is an extra bit annoying here because they seem to always localize the string "Episode" even if the title itself isn't localized, so you get titles like "Gintama Folge 1 – You Guys!! Do You Even Have a Gintama? (Part 1)".
The URLs I give youtube-dl are from the en-US site (not crunchyroll.com/de/) and if I opened the same URL in an incognito window, I'd get the en-US site by default (both browser and system locale are en-US).
A possible workaround is to use crunchyroll.com/en-gb/ URLs to force at least the English language but there might be small differences between the en-GB and en-US site and it shouldn't be necessary.

Would it be possible to get the CR metadata in the language of the system locale instead of letting CR decide the language based on my IP address?

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 5, 2019

For any work on this you must provide reproducible environment.

@dstftw dstftw closed this Feb 5, 2019
@Atemu
Copy link
Author

@Atemu Atemu commented Feb 5, 2019

This should be reproducible:

youtube-dl -v -e --proxy 46.101.107.98:8888  'https://www.crunchyroll.com/a-place-further-than-the-universe/episode-1-one-mwillion-yen-for-youth-757769' 
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-e', '--proxy', '46.101.107.98:8888', 'https://www.crunchyroll.com/a-place-further-than-the-universe/episode-1-one-mwillion-yen-for-youth-757769']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.01.30.1
[debug] Python version 3.7.2 (CPython) - Linux-4.20.6-arch1-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 4.1, ffprobe 4.1, rtmpdump 2.4
[debug] Proxy map: {'http': '46.101.107.98:8888', 'https': '46.101.107.98:8888'}
[debug] Default format spec: bestvideo+bestaudio/best
A Place Further Than the Universe Folge 1 – Die Jugend für eine Million Yen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.