Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bestaudio not so "best" after all? #19165

Closed
CatPlanet opened this issue Feb 7, 2019 · 2 comments
Closed

bestaudio not so "best" after all? #19165

CatPlanet opened this issue Feb 7, 2019 · 2 comments

Comments

@CatPlanet
Copy link

@CatPlanet CatPlanet commented Feb 7, 2019

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like this: [x])
  • Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


Description of your issue, suggested solution and other information

I'm not entirely sure if I should classity thiss issue as a bug so I decided to mark it as 'other'.
https://i.imgur.com/fRNJnz4.png
When using -f bestaudio parameter youtube-dl will use 171 format (it's new). However, as it shows on Spek's output, it's just 128k with nice and hard cut after 15kHz, compared to juicier 251 format.

You can clasify this a bug from user's perspective, but it's not a bug when you look at format output: 151k is more than 141k. On the other hand format description says completely different story.

@dstftw dstftw closed this Feb 7, 2019
@CatPlanet
Copy link
Author

@CatPlanet CatPlanet commented Feb 7, 2019

So, as I understand with just closing issue and leaving no comment, this is indended behavior?

@alexvong1995
Copy link
Contributor

@alexvong1995 alexvong1995 commented Feb 8, 2019

@CatPlanet

Firstly, next time please do not post images if you can post text. It is
impossible to copy and paste commands posted in an image.

Secondly, I agree with your assertion: 251 is of higher quality than 171
because the format of 251 is opus @160k, while the format of 171 is
vorbis@128k. Note that 251 has higher rated bitrate (160k) than that of
171 (128k). The fact that 251 has lower actual bitrate is precisely
because opus is meant to be a replacement for vorbis.
It provides better compression with no apparent loss in quality.

As we can see, the youtube-dl way of detecting best formats using the actual
bitrate is only a general heuristic. It does not always yield the best format.

However, I don't think changing the behaviour of youtube-dl is a good idea
because different users have different requirements. There isn't a simple way
to satisfy all users, e.g. I prefer free formats over patent-encumbered
formats (so vp8, vp9 > h264), as long as they have no worse resolution and
rated bitrate.

Therefore, I think we should follow the unix philosophy,
keeping youtube-dl minimal, and instead modularly create a script which takes a
list of formats and print the best format based on user configuration.

This can be done because youtube-dl can dump the list of formats as json.
Actually, this is something I want to do for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.